Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards: Add "import dashboard" to empty dashboard landing page #74018

Merged
merged 8 commits into from
Sep 1, 2023

Conversation

ivanortegaalba
Copy link
Contributor

@ivanortegaalba ivanortegaalba commented Aug 29, 2023

What is this feature?

As part of the data gathering we performed, we realized the "Add row" is not used.

In order to provide quick access to "Grafana.com" templates to new users, we decided to add "Import dashboard" to the empty state to allow them to find templates for their use case.

Before After
Captura de pantalla 2023-08-29 a las 16 16 49 Captura de pantalla 2023-08-29 a las 16 15 00

Who is this feature for?

New dashboard users

Which issue(s) does this PR fix?:

Fixes #73896

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ivanortegaalba ivanortegaalba requested review from a team as code owners August 29, 2023 14:12
@ivanortegaalba ivanortegaalba requested review from axelavargas, polibb, tskarhed and eledobleefe and removed request for a team August 29, 2023 14:12
@ivanortegaalba ivanortegaalba changed the title Replace "Add row" by "import dashboard" in empty dashboard state Dashboards: Add "import dashboard" to empty dashboard landing page Aug 29, 2023
@ivanortegaalba ivanortegaalba requested review from Ijin08 and imatwawana and removed request for tskarhed and eledobleefe August 29, 2023 14:13
@ivanortegaalba ivanortegaalba added this to the 10.2.x milestone Aug 29, 2023
Copy link
Collaborator

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing the import tile body text to:

Import dashboards from files or grafana.com.

Also, this change affects the same screenshots as the PR #73688 so I'd suggest you just update those screenshots once to reflect both changes.

Copy link
Contributor

@Ijin08 Ijin08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanortegaalba ivanortegaalba merged commit 8113707 into main Sep 1, 2023
15 checks passed
@ivanortegaalba ivanortegaalba deleted the improve-ease-of-use-import-dashboard branch September 1, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve import dashboard UI
4 participants