Loki: Add backend healthcheck #74330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyax
reviewed
Sep 4, 2023
matyax
reviewed
Sep 4, 2023
pkg/tsdb/loki/healthcheck.go
Outdated
| return getHealthCheckMessage("There was an error returned querying the Loki API.", errors.New("invalid response")) | ||
| } | ||
|
|
||
| return getHealthCheckMessage("Successfully queried the Loki API.", nil) |
There was a problem hiding this comment.
This is the message we're going to show to the users, and I'm not sure about the concept of "querying the Loki API". How about:
- The data source test was successful.
- Successfully queried the Loki instance.
Or just the good old "Data source successfully connected.".
There was a problem hiding this comment.
Good suggestion! Changed it to Data source successfully connected..
matyax
approved these changes
Sep 4, 2023
|
Backend code coverage report for PR #74330
|
|
Frontend code coverage report for PR #74330
|
svennergr
requested review from
ashharrison90 and
JoaoSilvaGrafana
and removed request for
a team
chauchausoup
pushed a commit
to chauchausoup/grafana
that referenced
this pull request
Sep 15, 2023
* add loki healthcheck * remove `testDatasource` call * remove unused error check * change success message * improve error messages
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
* add loki healthcheck * remove `testDatasource` call * remove unused error check * change success message * improve error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Added the backend healthcheck based on the Prom implementation and https://grafana.com/docs/grafana/latest/developers/http_api/data_source/#check-data-source-health
Which issue(s) does this PR fix?:
Fixes #63726
Special notes for your reviewer:
http://localhost:3000/api/datasources/uid/DS_UID/healthand make sure to replaceDS_UID.