Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas: New circle/ellipse element #74389

Merged
merged 3 commits into from Sep 12, 2023
Merged

Canvas: New circle/ellipse element #74389

merged 3 commits into from Sep 12, 2023

Conversation

Develer
Copy link
Contributor

@Develer Develer commented Sep 5, 2023

What is this feature?

This PR provide new circle/ellipse canvas element.

Fixes #73656

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Develer Develer added add to changelog area/panel/canvas Issues related to canvas panel no-backport Skip backport of PR area/dataviz Anything that relates to Data Visualisation work but is not specific to one panel labels Sep 5, 2023
@Develer Develer added this to the 10.2.x milestone Sep 5, 2023
@Develer Develer self-assigned this Sep 5, 2023
@Develer Develer requested a review from a team as a code owner September 5, 2023 14:05
@drew08t
Copy link
Contributor

drew08t commented Sep 6, 2023

I tested it locally and it LGTM after the update to category!

drew08t
drew08t approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@drew08t drew08t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making those changes.

@Develer Develer merged commit d6bddf3 into main Sep 12, 2023
15 checks passed
@Develer Develer deleted the 73656-add-circle-element branch September 12, 2023 13:56
@nmarrs nmarrs mentioned this pull request Sep 14, 2023
Closed
chauchausoup pushed a commit to chauchausoup/grafana that referenced this pull request Sep 15, 2023
@Develer @chauchausoup
Canvas: New circle/ellipse element (grafana#74389)
046a01c 
* feat(canvas): add circle element
rwwiv pushed a commit that referenced this pull request Oct 2, 2023
@Develer @rwwiv
Canvas: New circle/ellipse element (#74389)
98bb5c4 
* feat(canvas): add circle element
@adela-almasan adela-almasan mentioned this pull request Oct 10, 2023
Closed
20 tasks
@nmarrs nmarrs mentioned this pull request Oct 19, 2023
Merged
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Oct 20, 2023
Merged
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
@dnhn dnhn mentioned this pull request Oct 24, 2023
Closed
@BrewTestBot BrewTestBot mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drew08t drew08t drew08t approved these changes

@nmarrs nmarrs Awaiting requested review from nmarrs

@adela-almasan adela-almasan Awaiting requested review from adela-almasan

Assignees

@Develer Develer

Labels
add to changelog area/dataviz Anything that relates to Data Visualisation work but is not specific to one panel area/frontend area/panel/canvas Issues related to canvas panel no-backport Skip backport of PR
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.

Canvas: Add basic circle element
3 participants
@Develer @drew08t @zerok