New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudWatch: Add AWS/S3 replication metrics (#74416) #74418
CloudWatch: Add AWS/S3 replication metrics (#74416) #74418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jordanefillatre ! Thanks for the contribution. Would you mind signing the CLA and reordering the new metrics to be in alphabetical order with the old ones?
Adding a link to the documentation: https://docs.aws.amazon.com/AmazonS3/latest/userguide/metrics-dimensions.html
Have you tried it and confirmed that it works? I noticed that the documentation didn't explicitly list the namespace
* Add S3 replications metrics to appropriate Namespace in NamespaceMetricsMap
98059f2
to
bce4985
Compare
Hi @iwysiu ,
It also show that I have omitted to add required dimensions. Last I've take more time to manually check manually the fix by running a dev environment. I can confirm that it works after last commit update: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for fixing the Dimensions and checking the namespace. Just one little alphabetization fix.
Co-authored-by: Isabella Siu <sakurablossom@blueblueworld.com>
Oh, so sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, I'll finish up the process stuff and then merge it. Thanks again for contributing!
…4418) Co-authored-by: Isabella Siu <sakurablossom@blueblueworld.com>
What is this feature?
Allow to use AWS S3 replication metrics using Cloudwatch datasource
Why do we need this feature?
Query "OperationsPendingReplication", "BytesPendingReplication", "ReplicationLatency", "OperationsFailedReplication" metrics
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #74416
Special notes for your reviewer:
Please check that: