Internationalization: Set lang of HTML page to user language preference #74513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypnos
requested review from
tskarhed and
ashharrison90
and removed request for
a team
|
|
grafana-pr-automation
bot
added
area/frontend
pr/external
joshhunt
added
no-backport
HTML "lang" attribute should reflect the actual language used in texts. Important for accessibility functions (screen readers), but also usable in CSS.
joshhunt
removed
the
no-changelog
joshhunt
changed the title
joshhunt
approved these changes
Sep 7, 2023
chauchausoup
pushed a commit
to chauchausoup/grafana
that referenced
this pull request
Sep 15, 2023
Adapt document language HTML "lang" attribute should reflect the actual language used in texts. Important for accessibility functions (screen readers), but also usable in CSS.
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
Adapt document language HTML "lang" attribute should reflect the actual language used in texts. Important for accessibility functions (screen readers), but also usable in CSS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Set "lang" attribute of
<html>element to the user language setting.Why do we need this feature?
HTML "lang" attribute should reflect the actual language used in texts.
It is important for accessibility functions (screen readers), but also usable in CSS.
Panel plugins can also read the lang attribute for i18n.
Who is this feature for?
International users.