Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas: Button API - Add support for GET requests #74566

Merged
merged 18 commits into from
Sep 11, 2023
Merged

Canvas: Button API - Add support for GET requests #74566

merged 18 commits into from
Sep 11, 2023

Conversation

adela-almasan
Copy link
Contributor

Adds support to GET method.

get.mov

Fixes #74218

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@adela-almasan adela-almasan added area/panel/canvas Issues related to canvas panel no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Sep 7, 2023
@adela-almasan adela-almasan added this to the 10.2.x milestone Sep 7, 2023
@adela-almasan adela-almasan self-assigned this Sep 7, 2023
@adela-almasan adela-almasan requested review from a team and Eve832 as code owners September 7, 2023 17:57
@adela-almasan adela-almasan requested review from L-M-K-B, eledobleefe and academo and removed request for a team September 7, 2023 17:57
academo
academo reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@academo academo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense, my main question is what happens with previously configured panels and the new default options?

It makes more sense to leave POST as the default option since it was the original default option too.

@adela-almasan adela-almasan mentioned this pull request Sep 10, 2023
Merged
3 tasks
@adela-almasan adela-almasan merged commit 89127d5 into main Sep 11, 2023
19 checks passed
@adela-almasan adela-almasan deleted the canvas_button_api_method branch September 11, 2023 13:03
chauchausoup pushed a commit to chauchausoup/grafana that referenced this pull request Sep 15, 2023
@adela-almasan @chauchausoup
Canvas: Button API - Add support for GET requests (grafana#74566)
733775a
@adela-almasan adela-almasan added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Sep 30, 2023
rwwiv pushed a commit that referenced this pull request Oct 2, 2023
@adela-almasan @rwwiv
Canvas: Button API - Add support for GET requests (#74566)
e2e1243
@adela-almasan adela-almasan mentioned this pull request Oct 10, 2023
Closed
20 tasks
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
@dnhn dnhn mentioned this pull request Oct 24, 2023
Closed
@BrewTestBot BrewTestBot mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@academo academo academo approved these changes

@Eve832 Eve832 Awaiting requested review from Eve832 Eve832 is a code owner

@L-M-K-B L-M-K-B Awaiting requested review from L-M-K-B L-M-K-B was automatically assigned from grafana/grafana-frontend-platform

@eledobleefe eledobleefe Awaiting requested review from eledobleefe eledobleefe was automatically assigned from grafana/grafana-frontend-platform

Assignees

@adela-almasan adela-almasan

Labels
add to changelog area/frontend area/panel/canvas Issues related to canvas panel no-backport Skip backport of PR type/docs
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.

Canvas: Button API Editor support GET requests
3 participants
@adela-almasan @academo @zerok