Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.0.x] Nested folders: Fix folder hierarchy in folder responses #74581

Merged
merged 1 commit into from Sep 8, 2023

Conversation

papagian
Copy link
Contributor

@papagian papagian commented Sep 8, 2023

Backport 9fcee9b from #74516


What is this feature?

#66835 modified the folder DTO to include the folder parents (if nested folders are enabled) to be used by the frontend the show the full path to Folders in the breadcrumbs.
When I implemented it I had in mind that ancestors not visible to the user (due to permissions) would be included as is and the frontend would handle them.
In retrospect, I realise that this problematic therefore I have made this fix that redacts their UID and the title instead.
It also fixes another bug (wrong guardian used) and populates correctly the canEdit, canView etc properties for ancestors.

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

Nested folders: Fix hierarchy in folder response

(cherry picked from commit 9fcee9b)
@papagian papagian requested a review from a team as a code owner September 8, 2023 08:10
@papagian papagian requested review from zserge, suntala and yangkb09 and removed request for a team September 8, 2023 08:10
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.0.x milestone Sep 8, 2023
@papagian papagian enabled auto-merge (squash) September 8, 2023 08:45
@papagian papagian modified the milestone: 10.0.x Sep 8, 2023
@papagian papagian merged commit 79a31f5 into v10.0.x Sep 8, 2023
16 checks passed
@papagian papagian deleted the backport-74516-to-v10.0.x branch September 8, 2023 08:54
@zerok zerok modified the milestones: 10.0.x, 10.0.7 Sep 19, 2023
@zerok zerok modified the milestones: 10.0.7, 10.0.9 Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants