Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas: Button API Editor support setting parameters #74637

Merged
merged 39 commits into from
Sep 18, 2023
Merged

Canvas: Button API Editor support setting parameters #74637

merged 39 commits into from
Sep 18, 2023

Conversation

adela-almasan
Copy link
Contributor

Adds parameters support to APIEditor.

request_params.mov

Test Dashboard:
buttonAPIDashboard.txt

Fixes #74220

Special notes for your reviewer:
#74566 needs to be merged first

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@adela-almasan
Button api support GET method
63641b6
@adela-almasan
Merge branch 'main' into canvas_button_api_method
846a860
@adela-almasan
remove required
95beab3
@adela-almasan
check for endpoint
76fb002
@adela-almasan
extract data
5fb1cfa
@adela-almasan
HttpRequestMethod enum
db80eb7
@adela-almasan
Merge branch 'main' into canvas_button_api_method
155ae1d
@adela-almasan
Merge branch 'main' into canvas_button_api_method
ba33adc
@adela-almasan
default method to GET
ce12419
@adela-almasan
lint
41ac6b5
@adela-almasan
add default api config; update default size and placement
aefbdb5
@adela-almasan
Merge branch 'main' into canvas_button_api_method
69c0ca6
@adela-almasan
lint fix
f722e0c
@adela-almasan
add type
c57f117
@adela-almasan
add defaults
2a0e364
@adela-almasan
Merge branch 'main' into canvas_button_api_method
3e1f223
@adela-almasan
default method to POST; updates
a1b591c
@adela-almasan
Merge branch 'canvas_button_api_method' into 74220_canvas_btn_params
6665cfc 
# Conflicts:
#	public/app/features/canvas/elements/button.tsx
#	public/app/plugins/panel/canvas/editor/element/APIEditor.tsx
@adela-almasan
lint
e1f0764
@adela-almasan
Merge branch 'canvas_button_api_method' into 74220_canvas_btn_params
1de9b7f
@adela-almasan
query params editor
323b923
@adela-almasan
Merge branch 'main' into 74220_canvas_btn_params
13b5733
@adela-almasan
add request headers
1a6672c
@adela-almasan
lint
dc344c1
@adela-almasan
Merge branch 'main' into canvas_button_api_method
87de8e0
@adela-almasan
Merge branch 'canvas_button_api_method' into 74220_canvas_btn_params
a8a473d
@adela-almasan adela-almasan added add to changelog area/panel/canvas Issues related to canvas panel no-backport Skip backport of PR labels Sep 10, 2023
@adela-almasan adela-almasan added this to the 10.2.x milestone Sep 10, 2023
Base automatically changed from canvas_button_api_method to main September 11, 2023 13:03
@adela-almasan adela-almasan requested review from a team and Eve832 as code owners September 11, 2023 13:03
@adela-almasan adela-almasan requested review from mckn and removed request for a team September 11, 2023 13:03
@adela-almasan
Merge branch 'main' into 74220_canvas_btn_params
82104a8 
# Conflicts:
#	public/app/features/canvas/elements/button.tsx
#	public/app/plugins/panel/canvas/editor/element/APIEditor.tsx
nmarrs
nmarrs reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consider updating the implementation to something we are comfortable with longer term - for this I think we should consider making how the param is sent in the API request a param by param setting vs global to make this feature less restrictive

public/app/features/canvas/elements/button.tsx Outdated Show resolved Hide resolved
public/app/plugins/panel/canvas/editor/element/QueryParamsEditor.tsx Outdated Show resolved Hide resolved
nmarrs and others added 3 commits September 14, 2023 13:24
@nmarrs
Fix betterer issues
8a270a7
@adela-almasan
Merge branch 'main' into 74220_canvas_btn_params
eb896a5 
# Conflicts:
#	public/app/features/canvas/elements/button.tsx
#	public/app/plugins/panel/canvas/editor/element/APIEditor.tsx
@adela-almasan
split params in query&header params
8e8082b
@adela-almasan
Copy link
Contributor Author

@nmarrs updated as per Luke's suggestion. I'll create a task for future improvements.
params

nmarrs
nmarrs approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach seems reasonable, great job!

@adela-almasan adela-almasan merged commit 0815d7f into main Sep 18, 2023
14 checks passed
@adela-almasan adela-almasan deleted the 74220_canvas_btn_params branch September 18, 2023 14:25
rwwiv pushed a commit that referenced this pull request Oct 2, 2023
@adela-almasan @rwwiv
Canvas: Button API Editor support setting parameters (#74637)
35be184
@adela-almasan adela-almasan mentioned this pull request Oct 10, 2023
Closed
20 tasks
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
@dnhn dnhn mentioned this pull request Oct 24, 2023
Closed
@BrewTestBot BrewTestBot mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashharrison90 ashharrison90 ashharrison90 left review comments

@nmarrs nmarrs nmarrs approved these changes

Assignees

@adela-almasan adela-almasan

Labels
add to changelog area/frontend area/panel/canvas Issues related to canvas panel no-backport Skip backport of PR
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.

Canvas: Button API Editor support setting parameters
4 participants
@adela-almasan @ashharrison90 @nmarrs @zerok