Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyroscope: Remove support for old pyroscope #74683

Merged
merged 10 commits into from
Sep 19, 2023

Conversation

aocenas
Copy link
Member

@aocenas aocenas commented Sep 11, 2023

What is this feature?

Removes support for old pyroscope backend and relevant client code. Also removes the backend type switch from the config page as it is not needed anymore.

Why do we need this feature?

For one there was a bit of confusion around the backend type selection and as we have Grafana Pyroscope v1 release the old pyroscope support is less relevant.

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Sep 11, 2023
@aocenas aocenas marked this pull request as ready for review September 11, 2023 16:10
@aocenas aocenas requested review from a team and lwandz13 as code owners September 11, 2023 16:10
@aocenas aocenas added no-backport Skip backport of PR add to changelog labels Sep 12, 2023
Copy link
Contributor

@joey-grafana joey-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Will need to update the text here
    Screenshot 2023-09-14 at 09 18 01

  • And in the docs
    Screenshot 2023-09-14 at 09 32 43

  • Running make devenv sources=phlare is fine, can connect to Phlare and query data. Running make devenv sources=pyroscope results in the following:
    Screenshot 2023-09-14 at 09 18 57

@aocenas
Copy link
Member Author

aocenas commented Sep 14, 2023

@joey-grafana thanks for noticing the docs and devenv stuff, should be all fixed now.

@aocenas aocenas requested a review from a team as a code owner September 14, 2023 13:57
@aocenas aocenas requested review from nikimanoledaki and yangkb09 and removed request for a team September 14, 2023 13:57
return err
}

res, err := d.client.LabelNames(ctx, query["query"][0], start, end)
Copy link
Member

@petethepig petethepig Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about this. Why remove query, start and end? Is it because we were not actually using them on the frontend?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the phlare client (which is also new pyroscope client) does not use it so we would just have unused args there. We actually send it from frontend so it will be easy to add them again once pyroscope supports it.

@aocenas aocenas merged commit f7aab06 into main Sep 19, 2023
20 checks passed
@aocenas aocenas deleted the aocenas/pyroscope/remove-support-old-pyro branch September 19, 2023 08:09
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants