Alerting: Indicate panels without identifier #74746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillesdemey
added
type/bug
area/alerting
gillesdemey
requested review from
VikaCep,
konrad147 and
soniaAguilarPeiron
and removed request for
a team
gillesdemey
commented
Sep 12, 2023
| @@ -73,11 +74,12 @@ export const DashboardPicker = ({ dashboardUid, panelId, isOpen, onChange, onDis | |||
|
|
|||
| const filteredPanels = | |||
| dashboardResult?.dashboard?.panels | |||
| ?.filter((panel): panel is PanelDTO => typeof panel.id === 'number' && typeof panel.type === 'string') | |||
There was a problem hiding this comment.
I removed the filter here, omitting the panels from the selection seemed confusing for the user
VikaCep
approved these changes
Sep 12, 2023
It doesn't to me, no. However it seems like the API does allow dashboards to be created with panels that have no identifiers so we just have to roll with it :D |
chauchausoup
pushed a commit
to chauchausoup/grafana
that referenced
this pull request
Sep 15, 2023
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Panel IDs are optional. This wasn't taken in to account in the
DashboardPickerand when opening the selector and choosing a dashboard that had any panels withoutidthe front-end would crash.The typings were both incorrect and also not correctly applied (
dashboardDTO.panelsis typed asany😖)This change shows the panels without identifiers but disables it from being selected and adds an indicator that those cannot be selected.