Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PublicDashboards: Title logo and footer redesign #74769

Merged
merged 25 commits into from
Oct 13, 2023
Merged

PublicDashboards: Title logo and footer redesign #74769

merged 25 commits into from
Oct 13, 2023

Conversation

juanicabanas
Copy link
Contributor

@juanicabanas juanicabanas commented Sep 12, 2023 •
edited
Loading

What is this feature?

It adds Grafana logo next to the title and also makes a UI modification in the footer

Why do we need this feature?

More adoption

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #62370

Special notes for your reviewer:
Related Enterprise PR

Light mode Dark mode
image image

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@juanicabanas juanicabanas added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Sep 12, 2023
@juanicabanas juanicabanas added this to the 10.2.x milestone Sep 12, 2023
@juanicabanas juanicabanas changed the title PublicDashboards: Logo title and footer redesign PublicDashboards: Title logo and footer redesign Sep 25, 2023
@juanicabanas juanicabanas marked this pull request as ready for review September 25, 2023 23:29
@juanicabanas juanicabanas requested review from tskarhed, ashharrison90, dprokop and ivanortegaalba and removed request for a team September 25, 2023 23:29
@juanicabanas juanicabanas added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Sep 25, 2023
chri2547
chri2547 reviewed Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look fine! Thank you for the contribution!

AgnesToulet
AgnesToulet approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@AgnesToulet AgnesToulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

docs/sources/setup-grafana/configure-grafana/configure-custom-branding/index.md Outdated Show resolved Hide resolved
@juanicabanas juanicabanas merged commit cdca151 into main Oct 13, 2023
16 checks passed
@juanicabanas juanicabanas deleted the juanicabanas/footer_logo branch October 13, 2023 16:18
Jguer pushed a commit that referenced this pull request Oct 13, 2023
@juanicabanas @AgnesToulet @Jguer
PublicDashboards: Title logo and footer redesign (#74769)
f882c7d 
---------

Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com>
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
darrenjaneczek pushed a commit that referenced this pull request Oct 23, 2023
@juanicabanas @AgnesToulet @darrenjaneczek
PublicDashboards: Title logo and footer redesign (#74769)
ddc5b7b 
---------

Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com>
@dnhn dnhn mentioned this pull request Oct 24, 2023
Closed
@BrewTestBot BrewTestBot mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chri2547 chri2547 chri2547 left review comments

@AgnesToulet AgnesToulet AgnesToulet approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

@tskarhed tskarhed Awaiting requested review from tskarhed tskarhed is a code owner automatically assigned from grafana/grafana-frontend-platform

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90 ashharrison90 is a code owner automatically assigned from grafana/grafana-frontend-platform

@dprokop dprokop Awaiting requested review from dprokop dprokop is a code owner automatically assigned from grafana/dashboards-squad

@ivanortegaalba ivanortegaalba Awaiting requested review from ivanortegaalba ivanortegaalba is a code owner automatically assigned from grafana/dashboards-squad

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

@mildwonkey mildwonkey Awaiting requested review from mildwonkey mildwonkey was automatically assigned from grafana/backend-platform

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki nikimanoledaki was automatically assigned from grafana/backend-platform

@evictorero evictorero Awaiting requested review from evictorero

Assignees
No one assigned
Labels
add to changelog area/backend area/frontend no-backport Skip backport of PR type/docs
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.

Task: Change pubdash footer and add title logo
4 participants
@juanicabanas @AgnesToulet @chri2547 @zerok