[v9.5.x] BrowseDashboards: Only remember the most recent expanded folder #74817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* BrowseDashboards: Only remember the most recent expanded folder * set to null * cleanup * only clear removed folder if it was the most recently opened * comments + variable (cherry picked from commit 5cb7eb5)
joshhunt
requested review from
kaydelaney,
ashharrison90 and
eledobleefe
and removed request for
a team
eledobleefe
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5cb7eb5 from #74617
What is this feature?
The old Browse Dashboards UI remembers opened folders and automatically loads their children when Browse or Search is opened. If the user has opened many folders, this can saturate the requests the frontend makes and prevents new requests (such as one for the user's search) from completing quickly.
This PR changers the old Browse Dashboards UI to only remember the last folder opened.
Why do we need this feature?
So the old Browse Dashboards UI performance does not get worse the more someone uses it.
Who is this feature for?
Everyone who isn't using new Browse Dashboards UI
Which issue(s) does this PR fix?:
Fixes #59543
Special notes for your reviewer:
Becuase this is in the old UI which we no longer dog food, we must manually test this throughly.
This is intended to be backported.