Admin: Use InteractiveTable for user and team tables #74821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarity-89
added
area/admin/user
add to changelog
area/teams
no-backport
Clarity-89
requested review from
joshhunt,
L-M-K-B,
eleijonmarck and
danielkenlee
and removed request for
a team,
L-M-K-B,
eleijonmarck and
danielkenlee
Should be fixed by #74888 |
|
I have added back the separate pagination component, seeing as the table will need to be modified to support backend pagination and sorting (will be done in a separate PR). |
# Conflicts: # public/app/features/admin/UserListAdminPage.tsx
tskarhed
reviewed
Sep 21, 2023
| export const Avatar = ({ src, alt }: AvatarProps) => { | ||
| const styles = useStyles2(getStyles); | ||
|
|
||
| if (!src) { |
There was a problem hiding this comment.
Is this for the case where an image hasn't been loaded yet?
There was a problem hiding this comment.
It's a carry over from the previous implementation where the image src type is optional, I guess it can be missing in some cases.
joshhunt
reviewed
Sep 21, 2023
joshhunt
reviewed
Sep 21, 2023
joshhunt
approved these changes
Sep 26, 2023
otilor
pushed a commit
to otilor/grafana
that referenced
this pull request
Sep 28, 2023
* Admin: Use InteractiveTable * Admin: Fix pagination * Admin: Use CellWrapper * Admin: Split components * Admin: Separate OrgUsersTable * Admin: Remove UsersTable * Admin: Use the new table for TeamList * Admin: Cleanup TeamList page * Admin: Add edit team action * Admin: Use explicit edit action instead of a link wrapper * Admin: Fix responsive styles * Cleanup * Remove redundant sort * Add item key * Fix icon styles * Set loading by default * Use separate pagination component * Use default sorting functionality * Fix merge conflicts * Update betterer * Move pagination inside OrgUsersTable.tsx * Disable sort if results have more than 1 page * Update betterer results * Use CSS objects * More style fixes * Update betterer
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
* Admin: Use InteractiveTable * Admin: Fix pagination * Admin: Use CellWrapper * Admin: Split components * Admin: Separate OrgUsersTable * Admin: Remove UsersTable * Admin: Use the new table for TeamList * Admin: Cleanup TeamList page * Admin: Add edit team action * Admin: Use explicit edit action instead of a link wrapper * Admin: Fix responsive styles * Cleanup * Remove redundant sort * Add item key * Fix icon styles * Set loading by default * Use separate pagination component * Use default sorting functionality * Fix merge conflicts * Update betterer * Move pagination inside OrgUsersTable.tsx * Disable sort if results have more than 1 page * Update betterer results * Use CSS objects * More style fixes * Update betterer
mildwonkey
pushed a commit
that referenced
this pull request
Oct 4, 2023
* Admin: Use InteractiveTable * Admin: Fix pagination * Admin: Use CellWrapper * Admin: Split components * Admin: Separate OrgUsersTable * Admin: Remove UsersTable * Admin: Use the new table for TeamList * Admin: Cleanup TeamList page * Admin: Add edit team action * Admin: Use explicit edit action instead of a link wrapper * Admin: Fix responsive styles * Cleanup * Remove redundant sort * Add item key * Fix icon styles * Set loading by default * Use separate pagination component * Use default sorting functionality * Fix merge conflicts * Update betterer * Move pagination inside OrgUsersTable.tsx * Disable sort if results have more than 1 page * Update betterer results * Use CSS objects * More style fixes * Update betterer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Use the new
InteractiveTablecomponent for user and team tables in admin.The new component has been introduced for the following pages:
Why do we need this feature?
To make the UI more consistent and enable sorting for these tables.
Which issue(s) does this PR fix?:
Fixes #74658
Special notes for your reviewer:
Not a part of this PR and will need a follow-up work:
Please check that: