Feature: Allow to disable a plugin

[andresmgot]

What is this feature?

Add the possibility to skip loading a plugin, including core plugins (but not limited to those).

Why do we need this feature?

An operator may want to disable a plugin.

Who is this feature for?

Grafana operators.

Which issue(s) does this PR fix?:

Fixes https://github.com/grafana/grafana-operator-experience-squad/issues/614

Special notes for your reviewer:

Note that I have skipped adding a feature flag for this featue since it won't be used unless it's configured. Let me know if you still think a feature flag is necessary.

Please check that:

• It works as expected from a user's perspective.
• If this is a pre-GA feature, it is behind a feature toggle.
• The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

[torkelo]

I think this looks good

[xnyo]

LGTM! 🚀

[wbrowne]

I think we could probably just do this within pluginsintegration, no? We can introduce the step there in here https://github.com/grafana/grafana/blob/main/pkg/services/pluginsintegration/pipeline/steps.go and then we also don't have to introduce a new config to the plugins config struct.

WDYT?

[chri2547]

docs look good! Thanks for the contribution!

[marefr]

LGTM with a nit

[marefr]

Nit. Would perhaps suggest renaming it to disabled_plugins. Something with "skip" that does feel weird to read for me without being able to pinpoint exactly why 😄

[andresmgot]

I think we could probably just do this within pluginsintegration, no?

Right, I always forget 👍

Nit. Would perhaps suggest renaming it to disabled_plugins

Sounds good to me 👍

[andresmgot]

and then we also don't have to introduce a new config to the plugins config struct.

@wbrowne as far as I can tell, the config change is still necessary because it's what's received in the pipeline but let me know if I am missing something.

[wbrowne]

and then we also don't have to introduce a new config to the plugins config struct.

@wbrowne as far as I can tell, the config change is still necessary because it's what's received in the pipeline but let me know if I am missing something.

Ah yeah I was thinking just also inject Grafana's *setting.Cfg there. I just worry that compared to some other config, someone might expect to set that and it automatically work (but won't because you need the right step). But also not a deal breaker!