New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Add export drawer when exporting all Grafana managed alerts #74846
Merged
soniaAguilarPeiron
merged 22 commits into
main
from
alerting/add-export-drawer-for-all-rulesss
Sep 18, 2023
Merged
Alerting: Add export drawer when exporting all Grafana managed alerts #74846
soniaAguilarPeiron
merged 22 commits into
main
from
alerting/add-export-drawer-for-all-rulesss
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rawer-in-policies-and-contact-points
…rawer-in-policies-and-contact-points
…ort formats when using GrafanaExportDrawer
…rawer-in-policies-and-contact-points
soniaAguilarPeiron
added
area/alerting
Grafana Alerting
area/frontend
add to changelog
no-backport
Skip backport of PR
add to what's new
labels
Sep 13, 2023
soniaAguilarPeiron
requested review from
gillesdemey,
VikaCep and
konrad147
and removed request for
a team
September 13, 2023 14:17
3 tasks
soniaAguilarPeiron
force-pushed
the
alerting/add-export-drawer-for-all-rulesss
branch
from
September 13, 2023 14:25
1f60d28
to
b7f910a
Compare
soniaAguilarPeiron
changed the title
Alerting: add export drawer when exporting all Grafana managed alerts
Alerting: Add export drawer when exporting all Grafana managed alerts
Sep 13, 2023
soniaAguilarPeiron
force-pushed
the
alerting/add-export-drawer-for-all-rulesss
branch
from
September 18, 2023 07:34
eba0c04
to
1d870d0
Compare
gillesdemey
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
soniaAguilarPeiron
deleted the
alerting/add-export-drawer-for-all-rulesss
branch
September 18, 2023 08:31
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
…#74846) * Add export formats drawer when exporting contact points * Add 'export by format' drawer in policies (root policy) * Add test for showing export policies button * Add tests for Policy.tsx * Add tests for export functionality in receivers * Add exporter drawer for receivers * Fix prettier warnings * Allow HCL only for alert rules exports * Add tests for Policies * Fix tests * Refactor: Update ExportProviders types for limiting the avaliable export formats when using GrafanaExportDrawer * Delete unused shouldShowExportOption method and tests * Add exporter drawer when clicking export all Grafana managed alerts * Fix test * fix prettier * lint --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
add to what's new
area/alerting
Grafana Alerting
area/frontend
no-backport
Skip backport of PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds export drawer when clicking Export all Grafana managed alert rules instead of downloading the export file immediately.
Why do we need this feature?
We want to unify experience when exporting data in alerting.
Who is this feature for?
All users.
Special notes for your reviewer:
export_all_rules.mp4
Please check that: