Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Add export drawer when exporting all Grafana managed alerts #74846

Merged
merged 22 commits into from Sep 18, 2023

Conversation

soniaAguilarPeiron
Copy link
Member

@soniaAguilarPeiron soniaAguilarPeiron commented Sep 13, 2023

What is this feature?

This PR adds export drawer when clicking Export all Grafana managed alert rules instead of downloading the export file immediately.

Why do we need this feature?

We want to unify experience when exporting data in alerting.

Who is this feature for?

All users.

Special notes for your reviewer:

export_all_rules.mp4

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@soniaAguilarPeiron soniaAguilarPeiron force-pushed the alerting/add-export-drawer-for-all-rulesss branch from 1f60d28 to b7f910a Compare September 13, 2023 14:25
@soniaAguilarPeiron soniaAguilarPeiron changed the title Alerting: add export drawer when exporting all Grafana managed alerts Alerting: Add export drawer when exporting all Grafana managed alerts Sep 13, 2023
@soniaAguilarPeiron soniaAguilarPeiron force-pushed the alerting/add-export-drawer-for-all-rulesss branch from eba0c04 to 1d870d0 Compare September 18, 2023 07:34
Copy link
Member

@gillesdemey gillesdemey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@soniaAguilarPeiron soniaAguilarPeiron merged commit 942c477 into main Sep 18, 2023
15 checks passed
@soniaAguilarPeiron soniaAguilarPeiron deleted the alerting/add-export-drawer-for-all-rulesss branch September 18, 2023 08:31
rwwiv pushed a commit that referenced this pull request Oct 2, 2023
…#74846)

* Add export formats drawer when exporting contact points

* Add 'export by format' drawer in policies (root policy)

* Add test for showing export policies button

* Add tests for Policy.tsx

* Add tests for export functionality in receivers

* Add exporter drawer for receivers

* Fix prettier warnings

* Allow HCL only for alert rules exports

* Add tests for Policies

* Fix tests

* Refactor: Update ExportProviders types for limiting the avaliable export formats when using GrafanaExportDrawer

* Delete unused shouldShowExportOption method and tests

* Add exporter drawer when clicking export all Grafana managed alerts

* Fix test

* fix prettier

* lint

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants