Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InteractiveTable: Add horizontal scroll #74888

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

Clarity-89
Copy link
Contributor

@Clarity-89 Clarity-89 commented Sep 14, 2023

What is this feature?

Add horizontal overflow to the table, so when it doesn't fit the viewport, it will scroll horizontally.

Why do we need this feature?

Improve the component's usage on smaller devices.

Which issue(s) does this PR fix?:

Fixes #63946

Special notes for your reviewer:

Before:

Screen.Recording.2023-09-14.at.8.01.56.mov

After:

Screen.Recording.2023-09-14.at.8.02.46.mov

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Clarity-89 Clarity-89 added this to the 10.2.x milestone Sep 14, 2023
@Clarity-89 Clarity-89 requested a review from a team as a code owner September 14, 2023 05:04
@Clarity-89 Clarity-89 requested review from joshhunt and L-M-K-B and removed request for a team September 14, 2023 05:04
@Clarity-89 Clarity-89 self-assigned this Sep 14, 2023
Copy link
Contributor

@tskarhed tskarhed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I find the story in Storybook a bit lacking, so if you ever feel the need to expand it, feel free. I was able to recreate the scroll in this case.

@Clarity-89 Clarity-89 merged commit 9fca10b into main Sep 21, 2023
29 checks passed
@Clarity-89 Clarity-89 deleted the interactive-table/overflow branch September 21, 2023 11:43
rwwiv pushed a commit that referenced this pull request Oct 2, 2023
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: Make table responsive for mobile
4 participants