[v10.1.x] Alerting: Prevent showing "Permissions denied" alert when not accurate #74925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
grafana-delivery-bot
bot
requested review from
gillesdemey,
VikaCep,
konrad147 and
soniaAguilarPeiron
and removed request for
a team
grafana-delivery-bot
bot
added
add to changelog
area/alerting
VikaCep
approved these changes
Sep 14, 2023
|
@VikaCep - hi, is this included in any release at the moment, or just merged? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport db2295b from #74887
What is this feature?
Users without org admin role were shown a "Permissions denied" alert in the creation/edition rule form even though they had access to create/edit the rule. The problem came after the
NotificationPreviewcomponent made a request to/api/v1/ngalert/alertmanagersin order to obtain external alertmanagers information which is an endpoint that requires that permission level.Turns out we don't actually need to call that endpoint to obtain that information.
Why do we need this feature?
To prevent showing the "Permissions denied" alert which is confusing and inaccurate.
Who is this feature for?
All users without org admin access.
Which issue(s) does this PR fix?:
Related to https://github.com/grafana/support-escalations/issues/7303
Before
After
