Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics: Add option to pass destSDKBaseURL to rudderstack load method #74926

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Analytics: Add option to pass destSDKBaseURL to rudderstack load method #74926

merged 3 commits into from
Oct 23, 2023

Conversation

gassiss
Copy link
Contributor

@gassiss gassiss commented Sep 14, 2023

What is this feature?

Adds an option to pass destSDKBaseURL to the Rudderstack SDK.

Why do we need this feature?

When loading the Rudderstack SDK version 1.1 or newer, this option can be passed to override the URL used to load SDK

Who is this feature for?

Any person that wants to override this option, and is using Rudderstack SDK version 1.1 or newer.

Which issue(s) does this PR fix?:

N/A

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@gassiss gassiss requested review from torkelo, a team and chri2547 as code owners September 14, 2023 14:59
@gassiss gassiss requested review from academo, ashharrison90, eledobleefe, papagian, zserge and nikimanoledaki and removed request for a team September 14, 2023 14:59
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Sep 14, 2023
@gassiss gassiss added no-backport Skip backport of PR add to changelog labels Sep 14, 2023
@gassiss gassiss changed the title Add option to pass destSDKBaseURL to rudderstack load method [Analytics]: Add option to pass destSDKBaseURL to rudderstack load method Sep 14, 2023
@gassiss gassiss changed the title [Analytics]: Add option to pass destSDKBaseURL to rudderstack load method Analytics: Add option to pass destSDKBaseURL to rudderstack load method Sep 14, 2023
chri2547
chri2547 reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of suggestions. Docs approved. Thanks for the contribution!

gassiss and others added 2 commits September 18, 2023 09:55
@gassiss @chri2547
Update docs/sources/setup-grafana/configure-grafana/_index.md
7f58202 
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
@gassiss @chri2547
Update docs/sources/setup-grafana/configure-grafana/_index.md
4a21d86 
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
chri2547
chri2547 reviewed Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs are approved. Thank you.

@joshhunt joshhunt merged commit 65a7bdd into main Oct 23, 2023
19 checks passed
@joshhunt joshhunt deleted the rudderstack-integrations-url-option branch October 23, 2023 12:43
@grafana-delivery-bot grafana-delivery-bot bot modified the milestones: 10.2.x, 10.3.x Oct 23, 2023
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chri2547 chri2547 chri2547 left review comments

@joshhunt joshhunt joshhunt approved these changes

@torkelo torkelo Awaiting requested review from torkelo torkelo is a code owner

@academo academo Awaiting requested review from academo academo is a code owner automatically assigned from grafana/frontend-ops

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90 ashharrison90 is a code owner automatically assigned from grafana/grafana-frontend-platform

@eledobleefe eledobleefe Awaiting requested review from eledobleefe eledobleefe is a code owner automatically assigned from grafana/grafana-frontend-platform

@papagian papagian Awaiting requested review from papagian papagian was automatically assigned from grafana/backend-platform

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki nikimanoledaki was automatically assigned from grafana/backend-platform

Assignees
No one assigned
Labels
add to changelog area/backend area/frontend no-backport Skip backport of PR type/docs
Projects
Grafana Frontend Platform
Archived in project
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gassiss @joshhunt @chri2547 @aangelisc