New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Update metrics for AWS/MediaConnect #74946
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deepali1211
requested review from
sarahzinger and
idastambuk
and removed request for
a team
September 14, 2023 18:18
grafana-pr-automation
bot
added
area/backend
datasource/CloudWatch
pr/external
This PR is from external contributor
labels
Sep 14, 2023
Deepali1211
force-pushed
the
update-MediaConnect-metrics
branch
from
September 14, 2023 19:00
2c897c5
to
680870a
Compare
iwysiu
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Deepali1211 ! Thanks for the contribution, it's a lot of metrics! Looking at the docs, it seems like we may still be missing the maintenance metrics Also, could you alphabetize the added metrics?
Deepali1211
force-pushed
the
update-MediaConnect-metrics
branch
from
September 18, 2023 16:07
680870a
to
ac234df
Compare
iwysiu
reviewed
Sep 18, 2023
Deepali1211
force-pushed
the
update-MediaConnect-metrics
branch
from
September 19, 2023 15:06
bfee010
to
b519a2c
Compare
iwysiu
approved these changes
Sep 19, 2023
michiboo
pushed a commit
to michiboo/grafana
that referenced
this pull request
Sep 19, 2023
pick 2f360e4 added Internationalization to table container
michiboo
pushed a commit
to michiboo/grafana
that referenced
this pull request
Sep 25, 2023
pick 2f360e4 added Internationalization to table container
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/backend
datasource/CloudWatch
no-backport
Skip backport of PR
pr/external
This PR is from external contributor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Added newer metrics for AWS/MediaConnect
Why do we need this feature?
To be updated
Who is this feature for?
grafana devs
Which issue(s) does this PR fix?:
Fixes #74883
Special notes for your reviewer:
Please check that: