Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update metrics for AWS/MediaConnect #74946

Merged
merged 2 commits into from Sep 19, 2023

Conversation

Deepali1211
Copy link
Contributor

What is this feature?

Added newer metrics for AWS/MediaConnect

Why do we need this feature?

To be updated

Who is this feature for?

grafana devs

Which issue(s) does this PR fix?:

Fixes #74883

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Deepali1211 Deepali1211 requested a review from a team as a code owner September 14, 2023 18:18
@Deepali1211 Deepali1211 requested review from sarahzinger and idastambuk and removed request for a team September 14, 2023 18:18
@CLAassistant
Copy link

CLAassistant commented Sep 14, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Deepali1211 ! Thanks for the contribution, it's a lot of metrics! Looking at the docs, it seems like we may still be missing the maintenance metrics Also, could you alphabetize the added metrics?

@iwysiu iwysiu added add to changelog no-backport Skip backport of PR labels Sep 18, 2023
@iwysiu iwysiu added this to the 10.2.x milestone Sep 18, 2023
@iwysiu iwysiu merged commit b54e4c0 into grafana:main Sep 19, 2023
10 of 11 checks passed
michiboo pushed a commit to michiboo/grafana that referenced this pull request Sep 19, 2023
pick 2f360e4 added Internationalization to table container
michiboo pushed a commit to michiboo/grafana that referenced this pull request Sep 25, 2023
pick 2f360e4 added Internationalization to table container
@Deepali1211 Deepali1211 deleted the update-MediaConnect-metrics branch October 5, 2023 15:05
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudWatch: Update metrics for AWS/MediaConnect
4 participants