Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PublicDashboards: Refresh ds plugin supported list #74947

Merged
merged 7 commits into from Sep 21, 2023

Conversation

juanicabanas
Copy link
Contributor

What is this feature?

After this PR, some datasources don't work and need some modifications. This can be checked here

This PR updates the documentation and the alert shown in the public dashboard modal when an unsupported datasource plugin is being used in the dashboard

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #74945

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@juanicabanas juanicabanas added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Sep 14, 2023
@juanicabanas juanicabanas added this to the 10.2.x milestone Sep 14, 2023
@juanicabanas juanicabanas requested review from axelavargas and ivanortegaalba and removed request for a team September 14, 2023 18:50
Copy link
Contributor

@evictorero evictorero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. We can leverage this PR to run the script on publicdashboards.go and commit the updated list.

@juanicabanas
Copy link
Contributor Author

Left some comments. We can leverage this PR to run the script on publicdashboards.go and commit the updated list.

The backend-generated list hasn't changed, because there's no way to know if a ds extends from DataSourceWithBackend or calls super.query from a backend layer. That's why I was forced to change it in the frontend method.

@evictorero
Copy link
Contributor

Left some comments. We can leverage this PR to run the script on publicdashboards.go and commit the updated list.

The backend-generated list hasn't changed, because there's no way to know if a ds extends from DataSourceWithBackend or calls super.query from a backend layer. That's why I was forced to change it in the frontend method.

I know but if you run it you will find some changes, I was wondering if we can add those changes in this PR as well.

@juanicabanas juanicabanas added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Sep 21, 2023
@juanicabanas juanicabanas merged commit 633605a into main Sep 21, 2023
21 checks passed
@juanicabanas juanicabanas deleted the juanicabanas/unsupported_ds_refresh branch September 21, 2023 19:24
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: change supported and unsupported datasources
3 participants