New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PublicDashboards: Refresh ds plugin supported list #74947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. We can leverage this PR to run the script on publicdashboards.go and commit the updated list.
...p/features/dashboard/components/ShareModal/SharePublicDashboard/SharePublicDashboardUtils.ts
Outdated
Show resolved
Hide resolved
...p/features/dashboard/components/ShareModal/SharePublicDashboard/SharePublicDashboardUtils.ts
Outdated
Show resolved
Hide resolved
The backend-generated list hasn't changed, because there's no way to know if a ds extends from DataSourceWithBackend or calls super.query from a backend layer. That's why I was forced to change it in the frontend method. |
I know but if you run it you will find some changes, I was wondering if we can add those changes in this PR as well. |
What is this feature?
After this PR, some datasources don't work and need some modifications. This can be checked here
This PR updates the documentation and the alert shown in the public dashboard modal when an unsupported datasource plugin is being used in the dashboard
Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #74945
Special notes for your reviewer:
Please check that: