New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NodeGraph: Allow to set node radius in dataframe #74963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! The update to the docs looks good. This just needs technical review now.
Hey @piggito, thanks for the PR, this look like a good feature and the code looks good so far but I am seeing some compilation issues. Are you able to fix those so we can test this? |
7be9ed1
to
ffd2e27
Compare
hi @aocenas , thank you for your feedback. |
Hey @piggito thanks for fixing those. Trying to test it now but when I try our test data source there are bunch of errors where it seems the edge is not computed correctly. I assume there is some issue with the node radius not being defaulted somewhere and thus creating NaNs. The node radius should be optional and so it should still work the same if it's not passed in the data frame. |
ffd2e27
to
3ab96a4
Compare
3ab96a4
to
d2e0b54
Compare
@aocenas I fixed the NaN errors, please can you have another look at it? |
@piggito looks good now. Thank you very much for the contribution 👍 |
Allow to set node radius in dataframe
What is this feature?
Allow to have an optional
nodeRadius
column in nodes dataframe to control node sizes.Why do we need this feature?
Currently all nodes have a fixed radius of 40 and different node radius could improve visualization.
Who is this feature for?
Admin users managing node graph
Which issue(s) does this PR fix?:
Fixes #74966
Special notes for your reviewer:
Please check that: