Trace View: Remove "deployment.environment" default traces 2 logs tag #74986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domasx2
changed the title
|
Backend code coverage report for PR #74986 |
|
Frontend code coverage report for PR #74986
|
connorlindsey
suggested changes
Sep 18, 2023
There was a problem hiding this comment.
We'll also need to remove it from the docs and settings tooltip. You can search for deployment.environment and see the following files:
docs/sources/datasources/jaeger/_index.mddocs/sources/datasources/zipkin/_index.mddocs/sources/datasources/tempo/_index.mdTraceToLogsSettings.tsx
connorlindsey
approved these changes
Sep 26, 2023
domasx2
deleted the
domas-trace-view-remove-deployment-environment-tag
branch
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-74986-to-v10.1.x origin/v10.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x bd452fe904abcfe07a0b6e4fc089ece22fc28bf7
# When the conflicts are resolved, stage and commit the changes
git add . && git cherry-pick --continueIf you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-74986-to-v10.1.x
# Create the PR body template
PR_BODY=$(gh pr view 74986 --json body --template 'Backport bd452fe904abcfe07a0b6e4fc089ece22fc28bf7 from #74986{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[v10.1.x] Trace View: Remove \"deployment.environment\" default traces 2 logs tag" --body-file - --label "type/bug" --label "type/docs" --label "area/explore" --label "area/frontend" --label "add to changelog" --label "area/panel/traceview" --label "backport" --base v10.1.x --milestone 10.1.x --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-74986-to-v10.1.x
# Create a pull request where the `base` branch is `v10.1.x` and the `compare`/`head` branch is `backport-74986-to-v10.1.x`.
# Remove the local backport branch
git switch main
git branch -D backport-74986-to-v10.1.x |
grafana-delivery-bot
bot
added
the
backport-failed
domasx2
added
no-backport
otilor
pushed a commit
to otilor/grafana
that referenced
this pull request
Sep 28, 2023
…grafana#74986) * Remove deployment.environment default tag * format * remove mentions from docs
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
…#74986) * Remove deployment.environment default tag * format * remove mentions from docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deployment.environmentis an OTEL semantic attribute, but unlikeservice.nameorservice.namespaceit is not automatically converted to a Loki label by Loki exporter or Grafana Agent. Thus it's very unlikely to exists and queries with it will return no data. It shouldn't be a default tag.