Cloudwatch: Backport 73524 Bring Back Legacy Log Group Picker #75031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudwatch: Add back support for old Log Group picker behind feature toggle. Fixes issue for aws gov cloud users
sarahzinger
requested review from
iwysiu and
kevinwcyu
and removed request for
a team
grafana-pr-automation
bot
added
datasource/CloudWatch
area/backend
area/frontend
labels
sarahzinger
added
no-backport
kevinwcyu
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
tested with a few simple queries + variable, and with cloudWatchCrossAccountQuerying toggled off and on. both look fine to me.
also compared the files to https://github.com/grafana/grafana/pull/73524/files#diff-5195d59bff5abb37dceeb2ba37e2e0acb2f73f861fc83e320a72f6e7b2784f18 and it looks like it matches, just that some files were moved around between the branches, but otherwise looks fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual Backport of #73524
We had an issue with AWS GovCloud where users were unable to use some newer APIs related to log groups, so we've brought back some older ui that used older APIs for existing GovCloud users until AWS is able to improve their api so that all users have access to it.
We had originally decided not to the backport this work because despite fixing a regression, it is arguably introducing new functionality and there's some room for risk that this will introduce additional bugs, however after some discussion, we've decided to backport as we hope the benefits outweigh the risks here.
That said would appreciate another set of eyes/manual testing in case I may have missed something.