Connections: Make the "Add new Connection" page work without internet access #75272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leventebalogh
added
area/plugins
area/plugins-catalog
type/bug
add to changelog
no-backport
leventebalogh
changed the title
mckn
reviewed
Sep 26, 2023
jackw
approved these changes
Sep 27, 2023
leventebalogh
deleted the
leventebalogh/make-catalog-work-without-internet
branch
otilor
pushed a commit
to otilor/grafana
that referenced
this pull request
Sep 28, 2023
… access (grafana#75272) * fix: make the "Add new Connection" page work without internet access * feat: update error message * fix: update the API url in the error log
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
… access (#75272) * fix: make the "Add new Connection" page work without internet access * feat: update error message * fix: update the API url in the error log
mildwonkey
pushed a commit
that referenced
this pull request
Oct 4, 2023
… access (#75272) * fix: make the "Add new Connection" page work without internet access * feat: update error message * fix: update the API url in the error log
This was referenced Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s): #74267
What changed?
Made the "Add new Connection" page and the Plugins Catalog work in case Grafana has no access to the internet, or if the internet connection is slow.
The problem
Currently the plugin list used by the frontend is merged from two sources: locally installed plugins (can contain plugins not available in our catalog), and remote plugins (available in our catalog on GCOM).
As the remote plugins are fetched through the internet (hitting https://grafana.com), it can happen that it takes more time, or even that it times out after 30 seconds if the access is blocked. Currently this is causing some of our pages to hang for 30 seconds, even though the instances are only planned to work with locally installed plugins.
The solution
The changes in this PR are trying to solve this in the following way:
1. Add New Connection - Normal behaviour
New.Connection.-.normal.mp4
2. Add New Connection - Slow remote response
New.Connection.-.slow.remote.mov
3. Add New Connection - Failing remote response
New.Connection.-.remote.error.mov
Fixes #74267.