Drawer: Make content scroll by default

[ashharrison90]

What is this feature?

• wraps the drawer content in a scrollbar by default
• deprecates the scrollableContent prop and marks it for removal in the next version
• removes all uses of scrollableContent in the core grafana codebase

Why do we need this feature?

• cleaner interface for the Drawer component

Who is this feature for?

• everyone! 🙌

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

• It works as expected from a user's perspective.
• If this is a pre-GA feature, it is behind a feature toggle.
• The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

[tskarhed]

Tried this for the use case where you don't want it to be scrollable, and it seems to work!

[axelavargas]

Mr Harrison 🕶️ code looks good to me, good job 🙌🏾 .

However, I wonder, if we are deprecating the property scrollableContent shouldn't we keep the old behavior to be backward compatible?

P.S. We could also update the Drawer.mdx to include this default behavior :)

[ashharrison90]

Mr Harrison 🕶️ code looks good to me, good job 🙌🏾 .

However, I wonder, if we are deprecating the property scrollableContent shouldn't we keep the old behavior to be backward compatible?

P.S. We could also update the Drawer.mdx to include this default behavior :)

good shout on restoring the old behaviour. i've done that, just made scrollableContent default.

re: updating the documentation; i'm not sure what i'd write. especially since we're deprecating the prop, we don't really want to encourage anyone to use it... "this component now scrolls exactly as you'd expect it to"? 😅 that's why i find this whole prop so weird. it's not something we should have ever exposed as a configuration option. this is just how the component should work.

[axelavargas]

re: updating the documentation; i'm not sure what i'd write. especially since we're deprecating the prop, we don't really want to encourage anyone to use it... "this component now scrolls exactly as you'd expect it to"? 😅 that's why i find this whole prop so weird. it's not something we should have ever exposed as a configuration option. this is just how the component should work.

That's a good point!

This component now scrolls exactly as you'd expect it to ---> 🤣 this made my day.