Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flamegraph: Fix css issues when embedded outside of Grafana #75369

Merged
merged 5 commits into from Sep 27, 2023

Conversation

aocenas
Copy link
Member

@aocenas aocenas commented Sep 25, 2023

What is this feature?

  • Fix z-index being high for search input
  • Fix tooltip table max-width
  • Set top margin for tooltip item text
  • Change the color of muted collapsed nodes so they don't stand up too much
Screenshot 2023-09-26 at 15 10 55
  • Add some gap between graph and table and also add subtle background to the table so it does not blend in with the graph.
Screenshot 2023-09-26 at 11 25 39
  • Use fallback color for diff mode where one side of the diff does not have data.

See: grafana/pyroscope#2346 (comment)

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks much better thx!

@aocenas aocenas merged commit 2a9ef4c into main Sep 27, 2023
17 checks passed
@aocenas aocenas deleted the aocenas/flamegraph/css-fixes-pyro branch September 27, 2023 09:50
otilor pushed a commit to otilor/grafana that referenced this pull request Sep 28, 2023
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants