Tempo: Use timezone of selected range for timestamps #75438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabrizio-grafana
changed the title
fabrizio-grafana
added
type/bug
add to changelog
no-backport
adrapereira
approved these changes
Sep 28, 2023
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
* Use timezone of selected range for timestamps * Fix tests
mildwonkey
pushed a commit
that referenced
this pull request
Oct 4, 2023
* Use timezone of selected range for timestamps * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Search or TraceQL tabs, users can select traces and filter them using a time range—traces outside of the specified time range are discarded. For this time range, Grafana uses by default the browser timezone, but the user can override it. However, when the user overrides the timezone, the timestamps of the returned traces are not formatted using the chosen timezone. This has been reported by at least one customer to be misleading.
This PR fixes the issue by resorting on the default formatting of the
Tablecomponent. Example of outcome when selecting traces for the last 6 hours at around 11:45 AM UTC: