Playlist: Remove unused/deprecated api and unused wrapper #75503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
requested review from
mildwonkey,
nikimanoledaki and
suntala
and removed request for
a team
ryantxu
added
no-backport
ryantxu
changed the title
ryantxu
commented
Sep 27, 2023
| return result | ||
| } | ||
|
|
||
| // Deprecated -- the frontend can do this better |
There was a problem hiding this comment.
the frontend was changed to skip this ~2 years ago. This function requires the playlist CRUD and dashboard search to know about eachother.
ryantxu
added
add to changelog
and removed
no-changelog
papagian
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Given that this route was included in the docs and the OpenAPI spec, maybe we should mark it as breaking change as well.
| @@ -7677,40 +7677,6 @@ | |||
| } | |||
| } | |||
| }, | |||
| "/playlists/{uid}/dashboards": { | |||
There was a problem hiding this comment.
we have to remove it also from
public/openapi3.json
note that they can be re-created both by using:
Lines 71 to 82 in d24dc7f
otilor
pushed a commit
to otilor/grafana
that referenced
this pull request
Sep 28, 2023
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
mildwonkey
pushed a commit
that referenced
this pull request
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the deprecated
/playlists/{uid}/dashboardsthat has not been used for a year+, and the unused dual write EntityAPI service.Release notice breaking change
The deprecated
/playlists/{uid}/dashboardsAPI endpoint has been removed. Dashboard information can be retrieved from the/dashboard/...APIs.