DataSourceAPI: Add adhoc filters to DataQueryRequest and make it not depend on global templateSrv #75552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to make it not depend on global templateSrv
torkelo
requested review from
dprokop,
ivanortegaalba,
tskarhed,
ashharrison90 and
sunker
and removed request for
a team
torkelo
removed request for
ivanortegaalba,
tskarhed,
ashharrison90 and
sunker
dprokop
reviewed
Sep 27, 2023
github-actions
bot
added
the
levitate breaking change
torkelo
removed
the
levitate breaking change
github-actions
bot
added
the
levitate breaking change
dprokop
approved these changes
Sep 28, 2023
This was referenced Oct 2, 2023
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
…depend on global templateSrv (#75552) * DataSourceAPI: Add adhoc filters to DataQueryRequest and some methods to make it not depend on global templateSrv * Minor tweaks/fixes * Renamed to filters * Fix test * Log deprecation warning * I give up
mildwonkey
pushed a commit
that referenced
this pull request
Oct 4, 2023
…depend on global templateSrv (#75552) * DataSourceAPI: Add adhoc filters to DataQueryRequest and some methods to make it not depend on global templateSrv * Minor tweaks/fixes * Renamed to filters * Fix test * Log deprecation warning * I give up
This was referenced Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem PR is trying to address
Goal is to stop needing to rely on a global adhoc filter set, to support local filters (for split views) and to have more control over which requests the filters should be applied to (instead of always ALL for the same data source).
Changes