Plugins: Fix sorting issue with expandable rows #75553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabrizio-grafana
changed the title
fabrizio-grafana
added
type/bug
add to changelog
no-backport
fabrizio-grafana
requested review from
a team,
oscarkilhed and
mdvictor
and removed request for
a team
|
Would be nice to have a test for this since manual testing with nested data is a bit of a hassle currently. |
aocenas
reviewed
Sep 29, 2023
|
@aocenas tried to clarify the code to address your comments. Let me know if you think it is enough! |
aocenas
approved these changes
Oct 3, 2023
|
Added a test for the main scenario of expansion and sorting of rows, the one that was causing the bug fixed in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rows are expandable and sortable, the two features currently clash, as reported in this escalation. This PR fixes such issue.
If we like this approach, we can then iterate to add tests.
Fixes #74443