Explore: Improve timeseries limit disclaimer #75587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyax
reviewed
Sep 27, 2023
| @@ -80,6 +80,7 @@ export function LogsVolumePanel(props: Props) { | |||
| anchorToZero | |||
| yAxisMaximum={allLogsVolumeMaximum} | |||
| eventBus={props.eventBus} | |||
| showAllTimeSeries | |||
There was a problem hiding this comment.
Should we also make this a state variable that the user can toggle at some point?
There was a problem hiding this comment.
whole context in https://raintank-corp.slack.com/archives/C02TXB92G6T/p1695815888660829
the TLDR is that this is just to unblock som other things, the logs volume panel can only have like 8 series i think (max 1 per each log level) so it's not really affected, we'll refactor this to make it better
gelicia
reviewed
Sep 27, 2023
gelicia
approved these changes
Sep 27, 2023
Co-authored-by: Kristina <kristina.durivage@grafana.com>
|
Backend code coverage report for PR #75587 |
|
Frontend code coverage report for PR #75587
|
otilor
pushed a commit
to otilor/grafana
that referenced
this pull request
Sep 28, 2023
* Explore: improve timeseries limit disclaimer * use object notation for style definition * increase gap * Update public/app/features/explore/Graph/GraphContainer.tsx Co-authored-by: Kristina <kristina.durivage@grafana.com> --------- Co-authored-by: Kristina <kristina.durivage@grafana.com>
3 tasks
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
* Explore: improve timeseries limit disclaimer * use object notation for style definition * increase gap * Update public/app/features/explore/Graph/GraphContainer.tsx Co-authored-by: Kristina <kristina.durivage@grafana.com> --------- Co-authored-by: Kristina <kristina.durivage@grafana.com>
mildwonkey
pushed a commit
that referenced
this pull request
Oct 4, 2023
* Explore: improve timeseries limit disclaimer * use object notation for style definition * increase gap * Update public/app/features/explore/Graph/GraphContainer.tsx Co-authored-by: Kristina <kristina.durivage@grafana.com> --------- Co-authored-by: Kristina <kristina.durivage@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Revamps the "Showing only 20 series" disclaimer in Explore:
Special notes for your reviewer:
The code is uglier then my hair right now, and the Graph is coupled with the container, but this should unblock #75499. Will create a follow up issue to do a tiny bit of refactoring as discussed with @gelicia to introduce a
limitprop the the ExploreGraph (instead of the current solution) so it'll be a bit cleanerPlease check that: