Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team: Support sort query param for teams search endpoint #75622

Merged
merged 9 commits into from
Sep 28, 2023
Merged

Conversation

gamab
Copy link
Contributor

@gamab gamab commented Sep 28, 2023

What is this feature?

Support sort query param for teams search endpoint
This scope param will allow to order (asc or desc) from the backend, the teams list based on name, email, memberCount fields.

Required by: #75228

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@gamab gamab added add to changelog no-backport Skip backport of PR labels Sep 28, 2023
@gamab gamab added this to the 10.2.x milestone Sep 28, 2023
@gamab gamab self-assigned this Sep 28, 2023
@gamab gamab requested review from a team as code owners September 28, 2023 10:16
@gamab gamab requested review from zserge, mildwonkey and suntala and removed request for a team September 28, 2023 10:16
@gamab
Copy link
Contributor Author

gamab commented Sep 28, 2023

I still need to do the docs :)

@Clarity-89
Copy link
Contributor

Works well, except the name sort seems to be broken, I've attached a screen recording.

Screen.Recording.2023-09-28.at.13.35.21.mov

Copy link
Contributor

@Clarity-89 Clarity-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and this works great! 🚀

@gamab gamab enabled auto-merge (squash) September 28, 2023 15:15
@gamab gamab merged commit 6ffd4a2 into main Sep 28, 2023
14 checks passed
@gamab gamab deleted the gamab/teams/sort branch September 28, 2023 15:20
rwwiv pushed a commit that referenced this pull request Oct 2, 2023
* Teams: Implement backend sorting

* Add docs

* Make name ordering case insensitive

* lint

* Fix no lowercasing on memberCount

* Add test to double check the filters or correctly OrderBy
mildwonkey pushed a commit that referenced this pull request Oct 4, 2023
* Teams: Implement backend sorting

* Add docs

* Make name ordering case insensitive

* lint

* Fix no lowercasing on memberCount

* Add test to double check the filters or correctly OrderBy
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants