Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: Improved Heatmap tooltip #75712

Merged
merged 87 commits into from
Nov 30, 2023
Merged

Tooltip: Improved Heatmap tooltip #75712

merged 87 commits into from
Nov 30, 2023

Conversation

adela-almasan
Copy link
Contributor

@adela-almasan adela-almasan commented Sep 29, 2023 •
edited

Heatmap tooltip using TooltipPlugin2

Blocked by
Dashboard: Overflow and z-index adjustments ✅
Tooltip: VizTooltip components #75794 ✅

hetmap_tooltip.mov

Fixes #75843
Fixes #76131

Test file
native_histogram_heatmap.json.txt

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@adela-almasan adela-almasan added this to the 10.2.x milestone Sep 29, 2023
@adela-almasan adela-almasan self-assigned this Sep 29, 2023
@grafana-pr-automation grafana-pr-automation bot added the area/panel/timeseries The main time series Graph panel label Sep 29, 2023
@adela-almasan adela-almasan marked this pull request as ready for review October 2, 2023 18:40
@adela-almasan adela-almasan requested review from joshhunt, JoaoSilvaGrafana and sunker and removed request for a team October 2, 2023 18:40
nmarrs
nmarrs reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take another look when #75794 is merged - overall this is looking great!

packages/grafana-ui/src/components/uPlot/plugins/ZoomXPlugin.tsx Outdated Show resolved Hide resolved
packages/grafana-ui/src/components/uPlot/plugins/index.ts Outdated Show resolved Hide resolved
public/app/plugins/panel/heatmap/HeatmapPanel.tsx Outdated Show resolved Hide resolved
public/app/plugins/panel/heatmap/module.tsx Outdated Show resolved Hide resolved
public/app/plugins/panel/heatmap/tooltip/HeatmapTooltip.tsx Outdated Show resolved Hide resolved
public/app/plugins/panel/heatmap/tooltip/tooltipUtils.ts Outdated Show resolved Hide resolved
Base automatically changed from leeoniya/heatmap-tooltip2-prep to main November 21, 2023 16:16
@leeoniya leeoniya merged commit e361839 into main Nov 30, 2023
20 checks passed
@leeoniya leeoniya deleted the heatmap_tooltip2 branch November 30, 2023 17:04
@adela-almasan adela-almasan mentioned this pull request Nov 30, 2023
Closed
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeoniya leeoniya leeoniya left review comments

@nmarrs nmarrs nmarrs approved these changes

@imatwawana imatwawana imatwawana approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

Assignees

@adela-almasan adela-almasan

Labels
add to changelog area/frontend area/panel/heatmap area/tooltip no-backport Skip backport of PR type/docs
Projects
None yet
Milestone
10.2.3
Development

Successfully merging this pull request may close these issues.

Improve native histogram tooltip visualization in heatmap Tooltip: Improved Heatmap tooltip
5 participants
@adela-almasan @nmarrs @leeoniya @imatwawana @aangelisc