Table: Make sparkline cell respect no value option. #75750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarkilhed
requested review from
a team,
codeincarnate and
mdvictor
and removed request for
a team
oscarkilhed
changed the title
codeincarnate
approved these changes
Sep 29, 2023
rwwiv
pushed a commit
that referenced
this pull request
Oct 2, 2023
Make sparkline respect no value option
mildwonkey
pushed a commit
that referenced
this pull request
Oct 4, 2023
Make sparkline respect no value option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Let's the user set the no value field config option to display when a sparkline cannot be created from the data.
Why do we need this feature?
If there is no data or the data can't be used for a sparkline we currently get a static "no data". This makes the sparkline respect the no value option.
Fixes #75352
Special notes for your reviewer:
Please check that: