-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformations: Rename "Transform" tab to "Transform data" #75757
Conversation
@catherineymgui what do you think of calling this "Transform Data"? It seems ok to me at least 😆 |
Sounds good to me! |
public/app/features/dashboard/components/PanelEditor/state/selectors.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like UI tests are expecting the tab name to be "Transform". Otherwise i think this is fine.
Yep! I'm fixing the tests now. Thanks Oscar! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seems like there still are some e2e's failing
This PR changes the "Transform" tab in the panel editor to read "Transform Data" instead to help give it further clarity. Still need to take a look and see if there are any docs that need to be updated.
Which issue(s) does this PR fix?:
Fixes #74209
Special notes for your reviewer:
Please check that: