Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformations: Rename "Transform" tab to "Transform data" #75757

Merged
merged 7 commits into from
Oct 4, 2023

Conversation

codeincarnate
Copy link
Collaborator

This PR changes the "Transform" tab in the panel editor to read "Transform Data" instead to help give it further clarity. Still need to take a look and see if there are any docs that need to be updated.

Which issue(s) does this PR fix?:

Fixes #74209

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@codeincarnate codeincarnate requested a review from a team as a code owner September 29, 2023 15:34
@codeincarnate codeincarnate requested review from dprokop and kaydelaney and removed request for a team September 29, 2023 15:34
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Sep 29, 2023
@codeincarnate codeincarnate requested review from oscarkilhed and mdvictor and removed request for dprokop and kaydelaney September 29, 2023 15:39
@codeincarnate
Copy link
Collaborator Author

@catherineymgui what do you think of calling this "Transform Data"? It seems ok to me at least 😆

@codeincarnate codeincarnate added the no-backport Skip backport of PR label Sep 29, 2023
@codeincarnate codeincarnate changed the title Transformations: Rename transform tab to transform data Transformations: Rename "Transform" tab to "Transform Data" Sep 29, 2023
@catherineymgui
Copy link
Contributor

Sounds good to me!

Copy link
Contributor

@oscarkilhed oscarkilhed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like UI tests are expecting the tab name to be "Transform". Otherwise i think this is fine.

@codeincarnate
Copy link
Collaborator Author

Yep! I'm fixing the tests now. Thanks Oscar! 🙏

@codeincarnate codeincarnate requested a review from a team as a code owner October 4, 2023 16:28
@codeincarnate codeincarnate requested review from tskarhed and ashharrison90 and removed request for a team, tskarhed and ashharrison90 October 4, 2023 16:28
Copy link
Contributor

@mdvictor mdvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems like there still are some e2e's failing

@codeincarnate codeincarnate changed the title Transformations: Rename "Transform" tab to "Transform Data" Transformations: Rename "Transform" tab to "Transform data" Oct 4, 2023
@codeincarnate codeincarnate merged commit d673862 into main Oct 4, 2023
16 checks passed
@codeincarnate codeincarnate deleted the transform/rename-tab branch October 4, 2023 19:24
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transform: Rename "Transform" Tab
6 participants