Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrowseDashboards: Enable new Browse Dashboards UI by default #75822

Merged
merged 3 commits into from Oct 5, 2023

Conversation

joshhunt
Copy link
Contributor

@joshhunt joshhunt commented Oct 2, 2023

What is this feature?

Enables the new Browse Dashboards UI by default. See What’s new in Grafana Cloud for more details

Apart from the easier to use and more performant UI, this change removes the 'General' folder from the frontend, and instead lists dashboards at the root level of the view, after folders. This is because the General folder was never a "real" folder, and so there were lots of inconsistencies with it - it couldn't be renamed or deleted. Permissions could not be managed on it, and alerts could not be stored within the General folder.

Which issue(s) does this PR fix?:

Fixes #64210
Fixes #51825
Fixes #59543

@joshhunt joshhunt added add to changelog no-backport Skip backport of PR labels Oct 2, 2023
@joshhunt joshhunt requested a review from a team as a code owner October 2, 2023 12:52
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Oct 2, 2023
@joshhunt joshhunt requested review from a team, ashharrison90 and L-M-K-B and removed request for a team October 2, 2023 12:58
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🙌

Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually i lied, need to rerun the feature toggle tests to regen the documentation correctly 👍

Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but then it looks great 😄

Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool 👍

@joshhunt joshhunt enabled auto-merge (squash) October 4, 2023 09:22
@joshhunt joshhunt force-pushed the joshhunt/newBrowseDashboards-ga branch from 0c46e96 to 6ad6dfb Compare October 5, 2023 10:03
@joshhunt joshhunt merged commit 3e2ca29 into main Oct 5, 2023
15 checks passed
@joshhunt joshhunt deleted the joshhunt/newBrowseDashboards-ga branch October 5, 2023 10:14
@joshhunt joshhunt changed the title BrowseDashboards: Enable new browse dashboards UI by default BrowseDashboards: Enable new Browse Dashboards UI by default Oct 9, 2023
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
@ChrisJBurns
Copy link

ChrisJBurns commented Oct 27, 2023

Just wanted to add for awareness, that this broke some of our permissions for viewing dashboards. We'd created some dashboards that were being applied into the General folder by default, and because it had grafana-editor permissions, non admins could see the dashboards. Now the dashboards are in root, only admins have permissions to see them.

We've created a folder now to resolve it, but just wanted to make folks aware incase you get issues raised from users who experienced the same.

@joshhunt
Copy link
Contributor Author

joshhunt commented Oct 27, 2023

@ChrisJBurns Are these dashboards provisioned? It sounds like you're running into #77082

Take note of the workaround:

A potential workaround until the fix is released would be for someone to log in as an Admin user and to manually set access to provisioned dashboards. This could either be done through the UI (using the dashboard and folder permissions tabs) or through API calls.

If you disable the new UI do the dashboards show up? You can disable the newBrowseDashboards feature toggle to narrow down the cause.

Just for context - The General folder has never actually existed. It's always been a weird fiction of the frontend, as a place to put dashboards that aren't in a folder (which is why things like Alerts could never be put in General, because "General" means "no folder" and Alerts require a folder), which is why we 'removed' it. It should be unlikely that this UI change impacts permissions on items, but stranger things have happened :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants