New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BrowseDashboards: Enable new Browse Dashboards UI by default #75822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually i lied, need to rerun the feature toggle tests to regen the documentation correctly 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but then it looks great 😄
31a2904
to
8a5adf3
Compare
2f641f0
to
0c46e96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool 👍
0c46e96
to
6ad6dfb
Compare
Just wanted to add for awareness, that this broke some of our permissions for viewing dashboards. We'd created some dashboards that were being applied into the General folder by default, and because it had We've created a folder now to resolve it, but just wanted to make folks aware incase you get issues raised from users who experienced the same. |
@ChrisJBurns Are these dashboards provisioned? It sounds like you're running into #77082 Take note of the workaround:
If you disable the new UI do the dashboards show up? You can disable the Just for context - The General folder has never actually existed. It's always been a weird fiction of the frontend, as a place to put dashboards that aren't in a folder (which is why things like Alerts could never be put in General, because "General" means "no folder" and Alerts require a folder), which is why we 'removed' it. It should be unlikely that this UI change impacts permissions on items, but stranger things have happened :) |
What is this feature?
Enables the new Browse Dashboards UI by default. See What’s new in Grafana Cloud for more details
Apart from the easier to use and more performant UI, this change removes the 'General' folder from the frontend, and instead lists dashboards at the root level of the view, after folders. This is because the General folder was never a "real" folder, and so there were lots of inconsistencies with it - it couldn't be renamed or deleted. Permissions could not be managed on it, and alerts could not be stored within the General folder.
Which issue(s) does this PR fix?:
Fixes #64210
Fixes #51825
Fixes #59543