New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Monitor: Add 5 curated dashboards for App insights troubleshooting experience #75916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yves-chan! Thank you for contributing! I've reviewed this and just have some changes to request:
Most of the dashboard variables e.g. operationName
or resultCode
should use a query that begins with search "*"
. Whilst this query is inefficient, it avoids errors in the dashboard where a user may not have requests that have failed and overall provides a nicer UX. WDYT?
Additionally, once this change has been made could you run prettier --fix public/app/plugins/datasource/azuremonitor
to ensure the files have the correct styling.
Thank you!
oh great idea, it is way better to have an experience without failures upon load. Let me also run the prettier fixes, I will tag you again when these changes are in :) thanks! |
@aangelisc regarding the search keyword do you mind giving me an example? I'm not sure I'm using it correctly
|
Hey @yves-chan, thank you for working on this so quickly. This is what I had in mind:
This should be the case for all the variables to avoid empty data in dashboard panels where possible 😊 |
@aangelisc |
@aangelisc Can I get another review on this please 😄 ? |
Hi @yves-chan, I still have the same issue. See the image below: This is because the See my updated |
hey @aangelisc thanks for the follow up! I believe that this case should be handled in the query themselves. I default a custom value of "All", which gets passed in the queries and the KQL queries should still be syntactically correct even if there's no data For cases like the I haven't been able to reproduce the case where there's no data and the panel fails, are you able to inspect the query and share the request and response details for one of the failed panels? |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yves-chan,
Never mind me, I didn't have your latest updates locally! I've checked and everything looks great now! Once the build succeeds I'll merge this. Thank you!
Could you merge main please @yves-chan? |
@aangelisc Just merged main to this branch, thanks! |
…ing experience (#75916) * initial changes * fix indent * fix some bugs, and update fit and finish * remove inputs * change ms.portal to portal * add new dashboards, fix some links and queries * fix more links * update the default time ranges * prettier fix dashboards * update log query variables with search '*' * default the variable value to All * missed a few spots to assume that the values of the variable are in an array * fix queries for min and max duraation as well * keep variables naming consistent * fix missing parenthesis in dependencies operation query * fix some links, change todouble instead of tollong
What is this feature?
This PR adds some troubleshooting experiences for Azure Application Insights. It will use the new trace view for the Azure Monitor datasource to view the traces from Azure Application Insights. Included are drilldown experiences for Performance on operations and dependencies, and drill down experiences for Failures on operations, dependencies, and exceptions.
Why do we need this feature?
This feature helps customers of Grafana using Azure Application Insights troubleshoot requests by using the new Azure Monitor trace to view the trace details.
Who is this feature for?
This feature is for customers who monitor their applications using Azure Application Insights and want to troubleshoot requests, dependencies, and exceptions with the help of traces.
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: