Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.1.x] Alerting: Make shareable alert rule link work if rule name contains forward slashes #75950

Merged
merged 1 commit into from Oct 4, 2023

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport aaaef71 from #75362


URL produced by "Copy link to rule" button would not open the rule page on Grafana Cloud instances if alert name contains forward slashes. This is because proxy in front of grafana auto unescapes slashes thereby mangling the URL.

This is solved by using unescapePathSeparators and escapePathSeparators which are intended to solve this exact problem and are used for rule id, but were not being used for the short link.

Fixes #74807

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@grafana-delivery-bot grafana-delivery-bot bot requested a review from a team as a code owner October 4, 2023 11:50
@grafana-delivery-bot grafana-delivery-bot bot requested review from gillesdemey, VikaCep, konrad147 and soniaAguilarPeiron and removed request for a team October 4, 2023 11:50
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.1.x milestone Oct 4, 2023
@grafana-delivery-bot grafana-delivery-bot bot added add to changelog area/alerting Grafana Alerting area/frontend backport A backport PR internal for issues made by grafanistas type/bug labels Oct 4, 2023
@gillesdemey gillesdemey merged commit d6c3bff into v10.1.x Oct 4, 2023
19 checks passed
@gillesdemey gillesdemey deleted the backport-75362-to-v10.1.x branch October 4, 2023 16:40
@aangelisc aangelisc modified the milestones: 10.1.x, 10.1.6 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/alerting Grafana Alerting area/frontend backport A backport PR internal for issues made by grafanistas type/bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants