Plugins: Add feat toggle to install managed plugins #75973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshirohugo
force-pushed
the
add-managed-plugins-install-feat-toggle
branch
from
17a7df6
to
c166104
Compare
oshirohugo
requested review from
a team,
wbrowne,
marefr and
andresmgot
and removed request for
a team
marefr
approved these changes
Oct 18, 2023
pkg/services/featuremgmt/registry.go
Outdated
| Name: "managedPluginsInstall", | ||
| Description: "Install managed plugins directly from plugins catalog", | ||
| Stage: FeatureStageExperimental, | ||
| RequiresDevMode: true, |
There was a problem hiding this comment.
I wanted to be safe and test it before going to production.
Will this make my installation tests more difficult to perform? (I don't know much about our environments)
There was a problem hiding this comment.
Changed anyway XD
There was a problem hiding this comment.
Would require app_mode=development I think which is not enabled in cloud. Merging this the feature toggle will be disabled unless configured to be enabled
There was a problem hiding this comment.
Tks for pointing this out!
andresmgot
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Add feat toggle to install managed plugins
Why do we need this feature?
This is necessary to control the availability of new feature https://github.com/grafana/grafana-plugins-platform-team/issues/21
release.
Who is this feature for?
Grafana Developers
Which issue(s) does this PR fix?:
This is part of https://github.com/grafana/grafana-plugins-platform-team/issues/21
Special notes for your reviewer:
Please check that: