Bar Gauge: Add max height option

[Develer]

What is this feature?

This PR add new option for max height of bar in horizontal orientation.

Fixes #75982

Special notes for your reviewer:

Please check that:

• It works as expected from a user's perspective.
• If this is a pre-GA feature, it is behind a feature toggle.
• The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

For doc changes see #76240

[github-actions]

⚠️   Possible breaking changes

(Open the links below in a new tab to go to the correct steps)

grafana-ui has possible breaking changes (more info)

Console output
Read our guideline

[nmarrs]

Overall looks good! We should also update the bar gauge docs (index.md) file with this added property - that can be done in a follow-up PR though ;)

[torkelo]

Is this really needed? Been many years like without any request for this option.

[Develer]

@nmarrs
I was so obsessed with reducing the number of options that I decided to make layout orientation and bar sizing options dependent on each other. And now I see that it doesn't make much sense, thanks for pointing it out.

[Develer]

@nmarrs There is one point to discuss.

I want to show specific sizing options for selected layout orientation. For example, to display Min width for vertical. layout orientation only, to avoid options overwhelming.

I didn't find any proper way to show/hide sizing options for specific layout orientations. For example, if there is auto layout orientation we can't say the exact orientation, so we can't decide which sizing options to show or hide. So right now it's gonna be displayed all sizing options both for vertical and horizontal layout.
Btw, the same situation happening with the Name placement option.

I decided to add an extra description to each sizing option. What do you think?

[nmarrs]

I think this is reasonable :) I think this is good to show off to Torkel / get this thoughts / approval

[nmarrs]

I think we can still make the manual options a function of layout orientation right?

for auto we show all

for horizontal we show max / min height

for vertical we just show width

With this I think we can keep the description explicitely saying what they are for / apply, which is especially useful in auto mode

[Develer]

Hi @torkelo,
Here is an implementation we came up with. Showing/hiding sizing options depends on orientation and auto/manual sizing mode. We are also showing all sizing options in manual sizing mode and auto layout orientation. Let us know what you think.

Screen.Recording.2023-11-03.at.12.19.48.mov

[torkelo]

@Develer looks great

[Leviathan09]

So now that we have "Bar Size" i have to update all my Panels and Dashboards with a new Min height value to correct that poor implementation
Why would you keep the "Auto" function when it doesn't work?
I have to edit now every single Panel and all my Dashboards.

Not amused !

[torkelo]

@nmarrs @Develer these changes sadly these changes to the defaults that are still used in "auto" mode completely and utterly break the auto mode. The sad part is that we cannot just restore the values to fix it as any saved dashboard will be saved with these new values.

but maybe the fix is just to not use these defaults in auto mode.

[torkelo]

wait, no we can just change these. even though they are persisted the defaults are directly used when sizing is set to auto

[nmarrs]

@Leviathan09 we are sorry for introducing this bug / regression and for the headache that it caused :/ This was not our intention and we have merged a PR to fix this asap (will be in v10.3)