Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transformations: Add variable support to join by field #76056

Merged
merged 1 commit into from Oct 5, 2023
Merged

Transformations: Add variable support to join by field #76056

merged 1 commit into from Oct 5, 2023

Conversation

oscarkilhed
Copy link
Contributor

What is this feature?

Adds variable support to the join by field transformation.

A use-case for this was brought up in #25469

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@oscarkilhed oscarkilhed requested review from a team as code owners October 5, 2023 15:16
@oscarkilhed oscarkilhed requested review from tskarhed, ashharrison90 and academo and removed request for a team October 5, 2023 15:16
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Oct 5, 2023
codeincarnate
codeincarnate approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@codeincarnate codeincarnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, looks great 😄

@oscarkilhed oscarkilhed merged commit df9e767 into main Oct 5, 2023
33 checks passed
@oscarkilhed oscarkilhed deleted the oscark/join-by-field-variable branch October 5, 2023 22:03
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
@dnhn dnhn mentioned this pull request Oct 24, 2023
Closed
@BrewTestBot BrewTestBot mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeincarnate codeincarnate codeincarnate approved these changes

@tskarhed tskarhed Awaiting requested review from tskarhed tskarhed was automatically assigned from grafana/grafana-frontend-platform

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90 ashharrison90 was automatically assigned from grafana/grafana-frontend-platform

@academo academo Awaiting requested review from academo academo was automatically assigned from grafana/plugins-platform-frontend

Assignees
No one assigned
Labels
add to changelog area/frontend area/transformations no-backport Skip backport of PR
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oscarkilhed @codeincarnate @zerok