Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudWatch: Add missing GameLift metrics #76102

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

fridgepoet
Copy link
Member

@fridgepoet fridgepoet commented Oct 6, 2023

What is this feature?

This adds metrics for standard GameLift metrics which are currently not available

Originally #72805 by @Ciara-Cloud
Thanks also to @jangaraj for great suggestions on the original PR

Who is this feature for?

Users of CloudWatch

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2023

CLA assistant check
All committers have signed the CLA.

@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Oct 6, 2023
@fridgepoet fridgepoet changed the title Testing gamelift metrics CloudWatch: Add missing GameLift metrics Oct 6, 2023
@fridgepoet fridgepoet removed this from the 10.2.x milestone Nov 15, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@fridgepoet fridgepoet marked this pull request as ready for review November 15, 2023 16:49
@fridgepoet fridgepoet requested a review from a team as a code owner November 15, 2023 16:49
@fridgepoet fridgepoet requested review from idastambuk and kevinwcyu and removed request for a team November 15, 2023 16:49
@fridgepoet fridgepoet added this to the 10.3.x milestone Nov 15, 2023
@fridgepoet fridgepoet merged commit 9452a6f into main Nov 16, 2023
31 of 32 checks passed
@fridgepoet fridgepoet deleted the testing-gamelift-metrics branch November 16, 2023 09:02
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants