Service Accounts: Enable adding folder, dashboard and data source permissions to service accounts #76133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ievaVasiljeva <ieva.vasiljeva@grafana.com>
Jguer
requested review from
danielkenlee,
Clarity-89 and
JoaoSilvaGrafana
and removed request for
a team
IevaVasiljeva
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Whoop whoop 🚢
Two small comments (one code comment and one below), but apart from that all looks good!
Nit: maybe spell out the title? So ServiceAccounts: Add SAs to managed permissions -> Service Accounts: Enable adding folder, dashboard and data source permissions to service accounts. Just cause it goes in the change log, and people won't know what "managed permissions" means.
Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>
Jguer
changed the title
|
Great to see the change - thank you! Are you planning to also have a What's new section for this one? |
|
We can. it's not really new as we never stopped it in the backend and we added terraform support for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Allow adding Service accounts to Datasource, Dashboard and Folder Permissions.
Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: