Caching: Add feature toggle for memory efficient cache payload serialization #76145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md # packages/grafana-data/src/types/featureToggles.gen.ts # pkg/services/featuremgmt/registry.go # pkg/services/featuremgmt/toggles_gen.csv # pkg/services/featuremgmt/toggles_gen.go
mmandrus
changed the title
jcalisto
approved these changes
Oct 10, 2023
Comment on lines
30
to
32
| | `cloudwatchNewRegionsHandler` | Refactor of /regions endpoint, no user-facing changes | Yes | | ||
| | `nestedFolderPicker` | Enables the new folder picker to work with nested folders. Requires the nestedFolders feature flag | Yes | | ||
| | `accessTokenExpirationCheck` | Enable OAuth access_token expiration check and token refresh using the refresh_token | | |
There was a problem hiding this comment.
Correcting some minor formatting issues.
Suggested change
| | `cloudwatchNewRegionsHandler` | Refactor of /regions endpoint, no user-facing changes | Yes | | |
| | `nestedFolderPicker` | Enables the new folder picker to work with nested folders. Requires the nestedFolders feature flag | Yes | | |
| | `accessTokenExpirationCheck` | Enable OAuth access_token expiration check and token refresh using the refresh_token | | | |
| | `cloudwatchNewRegionsHandler` | Refactor of `/regions` endpoint, no user-facing changes | Yes | | |
| | `nestedFolderPicker` | Enables the new folder picker to work with nested folders. Requires the `nestedFolders` feature toggle | Yes | | |
| | `accessTokenExpirationCheck` | Enable OAuth access_token expiration check and token refresh using the `refresh_token` | | |
| | `prometheusConfigOverhaulAuth` | Update the Prometheus configuration page with the new auth component | Yes | | ||
| | `newBrowseDashboards` | New browse/manage dashboards UI | Yes | | ||
| | `cloudWatchWildCardDimensionValues` | Fetches dimension values from CloudWatch to correctly label wildcard dimensions | Yes | | ||
| | `cachingOptimizeSerializationMemoryUsage` | If enabled, the caching backend will gradually serialize query responses for the cache, comparing against the configured `[caching]max_value_mb` value as it goes, which can help prevent Grafana from running out of memory while attempting to cache very large query responses | | |
There was a problem hiding this comment.
Suggested change
| | `cachingOptimizeSerializationMemoryUsage` | If enabled, the caching backend will gradually serialize query responses for the cache, comparing against the configured `[caching]max_value_mb` value as it goes, which can help prevent Grafana from running out of memory while attempting to cache very large query responses | | | |
| | `cachingOptimizeSerializationMemoryUsage` | If enabled, the caching backend gradually serializes query responses for the cache, comparing against the configured `[caching]max_value_mb` value as it goes. This can can help prevent Grafana from running out of memory while attempting to cache very large query responses. | | |
| | `lokiMetricDataplane` | Changes metric responses from Loki to be compliant with the dataplane specification. | Yes | | ||
| | `dataplaneFrontendFallback` | Support dataplane contract field name change for transformations and field name matchers where the name is different | Yes | | ||
| | `alertingNotificationsPoliciesMatchingInstances` | Enables the preview of matching instances for notification policies | Yes | | ||
| | `useCachingService` | When turned on, the new query and resource caching implementation using a wire service inject will be used in place of the previous middleware implementation | | |
There was a problem hiding this comment.
Suggested change
| | `useCachingService` | When turned on, the new query and resource caching implementation using a wire service inject will be used in place of the previous middleware implementation | | | |
| | `useCachingService` | When active, the new query and resource caching implementation using a wire service inject replaces the previous middleware implementation. | | |
| | `gcomOnlyExternalOrgRoleSync` | Prohibits a user from changing organization roles synced with Grafana Cloud auth provider | | | ||
| | `prometheusMetricEncyclopedia` | Adds the metrics explorer component to the Prometheus query builder as an option in metric select | Yes | | ||
| | `prometheusResourceBrowserCache` | Displays browser caching options in Prometheus data source configuration | Yes | | ||
| | `prometheusDataplane` | Changes responses to from Prometheus to be compliant with the dataplane specification. In particular it sets the numeric Field.Name from 'Value' to the value of the `__name__` label when present. | Yes | |
There was a problem hiding this comment.
Suggested change
| | `prometheusDataplane` | Changes responses to from Prometheus to be compliant with the dataplane specification. In particular it sets the numeric Field.Name from 'Value' to the value of the `__name__` label when present. | Yes | | |
| | `prometheusDataplane` | Changes responses to from Prometheus to be compliant with the dataplane specification. In particular, when this feature toggle is active, the numeric `Field.Name` is set from 'Value' to the value of the `__name__` label. | Yes | |
darrenjaneczek
pushed a commit
that referenced
this pull request
Oct 23, 2023
…ization (#76145) * add feature toggle for smart cache serialization * re-add toggle after merge conflict * switch feature toggle stage to experimental * incorporate PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Creates a new feature toggle used by the enterprise caching feature.