A11y: Fix no-static-element-interactions in xy chart editor #76170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chauchausoup
requested review from
nmarrs and
drew08t
and removed request for
a team
grafana-pr-automation
bot
added
area/panel/xychart
area/frontend
pr/external
nmarrs
approved these changes
Oct 21, 2023
nmarrs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Fixes chore in TODOs.
Why do we need this feature?
To fix a11y in ManualEditor
Who is this feature for?
Everyone
Which issue(s) does this PR fix?:
Fixes this TODO :
grafana/public/app/plugins/panel/xychart/ManualEditor.tsx
Line 69 in 150d4d6
Special notes for your reviewer:
Please check that: