Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PluginExtensions: Made it possible to control modal size from extension #76232

Merged
merged 4 commits into from
Oct 12, 2023
Merged

PluginExtensions: Made it possible to control modal size from extension #76232

merged 4 commits into from
Oct 12, 2023

Conversation

mckn
Copy link
Contributor

@mckn mckn commented Oct 10, 2023 •
edited
Loading

What is this feature?

This PR will allow plugins that use UI extensions to control the size of the modal that will be displayed when calling openModal when an user trigger an UI extension.

You can specify width and height in either pixels or percent by passing it as options to the openModal function.

Why do we need this feature?

When opening more advanced flows when the user triggers an UI extension there is a need to control the size of the Modal.

Who is this feature for?

Plugin developers

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Oct 10, 2023
leventebalogh
leventebalogh approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👏

@mckn mckn self-assigned this Oct 10, 2023
@mckn mckn marked this pull request as ready for review October 10, 2023 14:10
@mckn mckn requested review from a team as code owners October 10, 2023 14:10
@mckn mckn requested review from tskarhed and L-M-K-B and removed request for a team October 10, 2023 14:10
leventebalogh
leventebalogh approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

academo
academo approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@academo academo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice test addition

@mckn mckn merged commit f012b75 into main Oct 12, 2023
19 checks passed
@mckn mckn deleted the mckn/size-modal-ui-extensions branch October 12, 2023 08:56
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
@dnhn dnhn mentioned this pull request Oct 24, 2023
Closed
@BrewTestBot BrewTestBot mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@academo academo academo approved these changes

@leventebalogh leventebalogh leventebalogh approved these changes

@tskarhed tskarhed Awaiting requested review from tskarhed tskarhed is a code owner automatically assigned from grafana/grafana-frontend-platform

@L-M-K-B L-M-K-B Awaiting requested review from L-M-K-B L-M-K-B is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees

@mckn mckn

Labels
add to changelog area/frontend area/plugin-extensions area/plugins/app App Plugins area/plugins no-backport Skip backport of PR
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mckn @academo @leventebalogh @zerok