Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Add provenance field to /api/v1/provisioning/alert-rules #76252

Merged

Conversation

grobinson-grafana
Copy link
Contributor

What is this feature?

This commit adds the missing Provenance field to responses for /api/v1/provisioning/alert-rules.

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

Fixes #76041

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

This commit adds the missing Provenance field to responses for
/api/v1/provisioning/alert-rules.
@grobinson-grafana grobinson-grafana requested review from a team, rwwiv, JacobsonMT and yuri-tceretian and removed request for a team October 10, 2023 10:55
@grobinson-grafana grobinson-grafana self-assigned this Oct 10, 2023
@grobinson-grafana grobinson-grafana added area/alerting Grafana Alerting add to changelog no-backport Skip backport of PR labels Oct 10, 2023
@grobinson-grafana grobinson-grafana added this to the 10.2.x milestone Oct 10, 2023
@grobinson-grafana grobinson-grafana changed the title Add provenance field to /api/v1/provisioning/alert-rules Alerting: Add provenance field to /api/v1/provisioning/alert-rules Oct 10, 2023
Copy link
Contributor

@yuri-tceretian yuri-tceretian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some tests would be great, though.

@grobinson-grafana
Copy link
Contributor Author

LGTM. Some tests would be great, though.

😄 That was fast! I thought I had more time to add the tests. I'm working on it and will push them up soon!

@grobinson-grafana grobinson-grafana merged commit 05e12e7 into main Oct 11, 2023
14 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/add-provenance-field-to-rules-response branch October 11, 2023 13:51
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Alerting: Provenance not set when retrieving all alerts
3 participants