Transformations: Move debug to drawer #76281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeincarnate
requested review from
a team,
oscarkilhed and
mdvictor
and removed request for
a team
mdvictor
requested changes
Oct 11, 2023
| @@ -122,7 +122,6 @@ export const TransformationOperationRow = ({ | |||
| )} | |||
| <QueryOperationToggleAction | |||
| title="Debug" | |||
| disabled={!isOpen} | |||
There was a problem hiding this comment.
I think with the removal of this we can also remove the arg in renderActions since isOpen is now unused.
|
Nice catch and what and odd issue! I'll see what is going on with the tooltip. |
|
@mdvictor I've been looking into it and I think that the issue with the debug tooltip is broader between tooltip/drawer interaction. I think that's enough to receive it's own PR honestly. WDYT? |
|
Actually saw an issue similar to this where putting a fix broke datalinks 😱. I think we very much want to avoid that outcome and make sure we address the tooltip issue overall 😄 |
|
Sounds like a good plan, I agree! |
mdvictor
approved these changes
Oct 13, 2023
oscarkilhed
approved these changes
Oct 13, 2023
ssama88
pushed a commit
to ssama88/grafana
that referenced
this pull request
Oct 31, 2023
* Move debug to drawer * Prettier * Remove render actions arg * Remove unused import
nikimanoledaki
pushed a commit
that referenced
this pull request
Nov 2, 2023
* Move debug to drawer * Prettier * Remove render actions arg * Remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR moves the transformation debug interface into a Drawer component for better usability.
Why do we need this feature?
Current transformation debug interface is inline and takes up a large amount of space within an already space constrained interface.
Which issue(s) does this PR fix?:
Fixes #74206
Special notes for your reviewer:
Please check that: