Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformations: Add context to transformation editor #76317

Merged
merged 2 commits into from Oct 12, 2023

Conversation

mdvictor
Copy link
Contributor

@mdvictor mdvictor commented Oct 11, 2023

What is this feature?

Adds context inside the transformation editor. This makes sure that a field calculation transformation which uses variables does get its variables interpolated and doesn't return undefined (and thus does creates a new field that is visible for other transforms further in the pipeline, e.g: organise).

Why do we need this feature?

Fix a bug where new fields created through field calc using variables where not visible in the final dataframe in the editor.

Who is this feature for?

Everyone

Which issue(s) does this PR fix?:

Fixes #76090

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@mdvictor mdvictor added area/transformations no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Oct 11, 2023
@mdvictor mdvictor requested review from a team, codeincarnate and oscarkilhed and removed request for a team October 11, 2023 05:53
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Oct 11, 2023
@mdvictor mdvictor requested review from a team as code owners October 11, 2023 09:54
@mdvictor mdvictor requested review from Clarity-89, ashharrison90 and academo and removed request for a team October 11, 2023 09:54
Copy link
Contributor

@oscarkilhed oscarkilhed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mdvictor mdvictor merged commit 4dfffa3 into main Oct 12, 2023
20 checks passed
@mdvictor mdvictor deleted the mdvictor/pass-transformation-when-using-vars branch October 12, 2023 05:43
@oscarkilhed oscarkilhed added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Oct 12, 2023
@oscarkilhed oscarkilhed changed the title Add context to transformation editor Transformations: Add context to transformation editor Oct 12, 2023
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants