Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore: Use short units in graphs #76358

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Explore: Use short units in graphs #76358

merged 1 commit into from
Oct 11, 2023

Conversation

Elfo404
Copy link
Member

@Elfo404 Elfo404 commented Oct 11, 2023 •
edited
Loading

What is this feature?

Uses short units in explore graph

a few examples:

Screenshot 2023-10-11 at 14 32 08
Screenshot 2023-10-11 at 14 31 28
Screenshot 2023-10-11 at 14 31 14
Screenshot 2023-10-11 at 14 31 09
Screenshot 2023-10-11 at 14 33 43

Why do we need this feature?

Makes it easier to read graphs in explore with big numbers.

Who is this feature for?

Explore users that look at graphs

Which issue(s) does this PR fix?:

Fixes #70166

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Elfo404 Elfo404 added add to changelog no-backport Skip backport of PR labels Oct 11, 2023
@Elfo404 Elfo404 requested a review from a team as a code owner October 11, 2023 13:30
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Oct 11, 2023
@github-actions
Copy link
Contributor

Backend code coverage report for PR #76358
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #76358

Plugin Main PR Difference
explore 85.21% 85.21% 0%

harisrozajac
harisrozajac approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@harisrozajac harisrozajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Elfo404 Elfo404 merged commit 54050be into main Oct 11, 2023
29 checks passed
@Elfo404 Elfo404 deleted the gio/feat/explore-short-units branch October 11, 2023 18:52
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
@dnhn dnhn mentioned this pull request Oct 24, 2023
Closed
@BrewTestBot BrewTestBot mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gelicia gelicia gelicia approved these changes

@harisrozajac harisrozajac harisrozajac approved these changes

Assignees
No one assigned
Labels
add to changelog area/explore area/frontend no-backport Skip backport of PR
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.

Use short units in Explore
4 participants
@Elfo404 @gelicia @harisrozajac @zerok